Skip to content
This repository was archived by the owner on Jul 30, 2026. It is now read-only.

feat: US-001 - Polish CVE-2026-42306 assessment comment to match existing pattern - #140

Merged
anota-fernandocosta merged 1 commit into
mainfrom
feature/issue-123-cve-2026-42306-comment
Jun 22, 2026
Merged

feat: US-001 - Polish CVE-2026-42306 assessment comment to match existing pattern#140
anota-fernandocosta merged 1 commit into
mainfrom
feature/issue-123-cve-2026-42306-comment

Conversation

@anota-fernandocosta

Copy link
Copy Markdown
Contributor

Description

Polishes the CVE-2026-42306 vulnerability assessment comment in api/dockers/api.go to match the format and detail level of the two existing assessments (GO-2026-4883 and CVE-2026-41567).

No fixed version available. HuskyCI uses Moby as client only.

Closes #123.

Changes

  • Added (US-001) suffix to the CVE-2026-42306 heading
  • Added current line numbers to all operation listings
  • Added 'only' qualifier to IMPORTS line

What Was Tested

  • Comment block format matches GO-2026-4883 and CVE-2026-41567 assessments
  • api/dockers/api.go passes gofmt -l (no formatting issues)
  • cd api && go build ./... passes
  • cd api && go vet ./... passes
  • cd api && go test -race -count=1 ./dockers/... passes
  • Full test suite across all 3 modules (api, client, cli) with no regressions

Co-Authored-By: Tamandua tamandua@tetradactyla.org

…ting pattern

- Add (US-001) suffix to CVE-2026-42306 heading
- Add line numbers to all operation listings (api.go:199, 215, 226, 247, 257, 275, 317+334, 351, 365+377, 383, 395)
- Add 'only' qualifier to IMPORTS line
- Align intro paragraph with existing assessment pattern

Co-Authored-By: Tamandua <tamandua@tetradactyla.org>
@anota-fernandocosta
anota-fernandocosta requested a review from a team as a code owner June 22, 2026 02:17

@anota-fernandocosta anota-fernandocosta left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Comment-only change that polishes the CVE-2026-42306 assessment to match the existing pattern.

What I verified:

  • ✅ Heading includes (US-001) suffix, matching GO-2026-4883 and CVE-2026-41567
  • ✅ All 11 container/image/misc operations include line numbers in (api.go:NNN) format
  • ✅ IMPORTS line reads (api/dockers/api.go only):
  • ✅ Comment structure (CONTAINER OPERATIONS / IMAGE OPERATIONS / MISC / IMPORTS / Status) matches the two existing assessments
  • gofmt -l api/dockers/api.go — clean (no formatting issues)
  • cd api && go build ./... — passes
  • cd api && go vet ./... — passes
  • cd api && go test -race -count=1 ./dockers/... — passes (44.9s)

No bugs, no edge case concerns, no security issues. Clean and consistent with project conventions.
DO NOT auto-merge.

@anota-fernandocosta
anota-fernandocosta merged commit 23614fd into main Jun 22, 2026
8 checks passed
anota-fernandocosta added a commit that referenced this pull request Jun 22, 2026
Main already contains CVE-2026-41567 assessment with (US-001) suffix
in the correct position via merged PRs #140 and #145. This branch's
comment reorder is no longer needed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: CVE-2026-42306 in api dependency github.com/docker/docker

1 participant