Skip to content

Expand daily Windows terminal integration builder with systematic Windows chaos scenarios#38132

Merged
pelikhan merged 2 commits into
mainfrom
copilot/update-agentic-workflow-scenarios
Jun 9, 2026
Merged

Expand daily Windows terminal integration builder with systematic Windows chaos scenarios#38132
pelikhan merged 2 commits into
mainfrom
copilot/update-agentic-workflow-scenarios

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The daily Windows terminal agentic workflow was under-specifying edge-case terminal configurations, leaving common Windows user/developer setup regressions under-tested. This PR tightens the builder prompt so generated integration workflows systematically exercise shell/environment/path variability and explicit hang-prone behaviors.

  • Scenario coverage model

    • Reframes integration checks as a matrix (shell × launch mode × environment shape × path style) instead of ad-hoc command checks.
    • Ensures scenario breadth is intentional and repeatable across updates.
  • Windows-specific chaos scenarios

    • Adds requirements for no-profile vs profile shell runs (pwsh, powershell, cmd paths).
    • Adds PATH/PATHEXT quirks, path-with-spaces/parentheses, mixed slashes, Unicode/non-ASCII paths, and common env toggles (NO_COLOR, TERM, CI, minimal envs).
    • Adds invocation-variant expectations (--help, help, subcommand help, unknown-command failure paths).
  • Failure behavior hardening

    • Requires at least one negative/chaos case that stresses terminal behavior and verifies failures are explicit, fast, and debuggable.
    • Keeps timeout/hang detection expectations front-and-center for Windows-specific regressions.
  • Compiled workflow sync

    • Recompiles the workflow so .lock.yml reflects the updated prompt contract.
- Treat scenario coverage as a systematic matrix (shell x launch mode x environment shape x path style) instead of ad-hoc spot checks.
- Include at least one negative/chaos case that intentionally stresses terminal behavior and verifies failure is explicit, fast, and debuggable.

Copilot AI and others added 2 commits June 9, 2026 14:56
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Expand Windows terminal scenario coverage in daily integration builder Expand daily Windows terminal integration builder with systematic Windows chaos scenarios Jun 9, 2026
Copilot AI requested a review from pelikhan June 9, 2026 15:03
@pelikhan pelikhan marked this pull request as ready for review June 9, 2026 16:17
Copilot AI review requested due to automatic review settings June 9, 2026 16:17
@pelikhan pelikhan merged commit 00ae4bc into main Jun 9, 2026
@pelikhan pelikhan deleted the copilot/update-agentic-workflow-scenarios branch June 9, 2026 16:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Daily Windows Terminal Integration Builder prompt to require broader, more systematic Windows terminal integration coverage (as a matrix of shell/launch/env/path scenarios), and regenerates the compiled .lock.yml to match the new prompt contract.

Changes:

  • Adds a scenario-coverage matrix requirement and enumerates Windows-specific chaos scenarios (shell profiles, PATH/PATHEXT quirks, path shapes, env toggles, invocation variants).
  • Requires at least one explicit negative/chaos case to validate fast, debuggable failure behavior (especially hang-prone cases).
  • Recompiles the builder workflow lockfile so the metadata hash reflects the updated prompt body.
Show a summary per file
File Description
.github/workflows/daily-windows-terminal-integration-builder.md Expands the prompt requirements to systematically cover Windows terminal/environment/path variability and explicit chaos/failure cases.
.github/workflows/daily-windows-terminal-integration-builder.lock.yml Regenerated compiled workflow lock metadata to reflect the updated builder prompt content.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

- Include chaos-style terminal/environment scenarios that mirror common Windows developer habits:
- no-profile shells (`pwsh -NoProfile`, `powershell -NoProfile`) and default profile shells
- PATH order and PATH shadowing quirks (workspace-first, toolcache-first, duplicate entries)
- PATHEXT and extension resolution behavior for `.exe` invocation from different shells
- no-profile shells (`pwsh -NoProfile`, `powershell -NoProfile`) and default profile shells
- PATH order and PATH shadowing quirks (workspace-first, toolcache-first, duplicate entries)
- PATHEXT and extension resolution behavior for `.exe` invocation from different shells
- paths with spaces/parentheses and mixed slash styles (`C:\\path with spaces\\...` and `/` vs `\\`)
- PATH order and PATH shadowing quirks (workspace-first, toolcache-first, duplicate entries)
- PATHEXT and extension resolution behavior for `.exe` invocation from different shells
- paths with spaces/parentheses and mixed slash styles (`C:\\path with spaces\\...` and `/` vs `\\`)
- unicode and non-ASCII working directories/user-profile-like paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants