Expand daily Windows terminal integration builder with systematic Windows chaos scenarios#38132
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Expand Windows terminal scenario coverage in daily integration builder
Expand daily Windows terminal integration builder with systematic Windows chaos scenarios
Jun 9, 2026
Copilot created this pull request from a session on behalf of
pelikhan
June 9, 2026 15:03
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Daily Windows Terminal Integration Builder prompt to require broader, more systematic Windows terminal integration coverage (as a matrix of shell/launch/env/path scenarios), and regenerates the compiled .lock.yml to match the new prompt contract.
Changes:
- Adds a scenario-coverage matrix requirement and enumerates Windows-specific chaos scenarios (shell profiles, PATH/PATHEXT quirks, path shapes, env toggles, invocation variants).
- Requires at least one explicit negative/chaos case to validate fast, debuggable failure behavior (especially hang-prone cases).
- Recompiles the builder workflow lockfile so the metadata hash reflects the updated prompt body.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/daily-windows-terminal-integration-builder.md | Expands the prompt requirements to systematically cover Windows terminal/environment/path variability and explicit chaos/failure cases. |
| .github/workflows/daily-windows-terminal-integration-builder.lock.yml | Regenerated compiled workflow lock metadata to reflect the updated builder prompt content. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 3
| - Include chaos-style terminal/environment scenarios that mirror common Windows developer habits: | ||
| - no-profile shells (`pwsh -NoProfile`, `powershell -NoProfile`) and default profile shells | ||
| - PATH order and PATH shadowing quirks (workspace-first, toolcache-first, duplicate entries) | ||
| - PATHEXT and extension resolution behavior for `.exe` invocation from different shells |
| - no-profile shells (`pwsh -NoProfile`, `powershell -NoProfile`) and default profile shells | ||
| - PATH order and PATH shadowing quirks (workspace-first, toolcache-first, duplicate entries) | ||
| - PATHEXT and extension resolution behavior for `.exe` invocation from different shells | ||
| - paths with spaces/parentheses and mixed slash styles (`C:\\path with spaces\\...` and `/` vs `\\`) |
| - PATH order and PATH shadowing quirks (workspace-first, toolcache-first, duplicate entries) | ||
| - PATHEXT and extension resolution behavior for `.exe` invocation from different shells | ||
| - paths with spaces/parentheses and mixed slash styles (`C:\\path with spaces\\...` and `/` vs `\\`) | ||
| - unicode and non-ASCII working directories/user-profile-like paths |
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily Windows terminal agentic workflow was under-specifying edge-case terminal configurations, leaving common Windows user/developer setup regressions under-tested. This PR tightens the builder prompt so generated integration workflows systematically exercise shell/environment/path variability and explicit hang-prone behaviors.
Scenario coverage model
shell × launch mode × environment shape × path style) instead of ad-hoc command checks.Windows-specific chaos scenarios
pwsh,powershell,cmdpaths).NO_COLOR,TERM,CI, minimal envs).--help,help, subcommand help, unknown-command failure paths).Failure behavior hardening
Compiled workflow sync
.lock.ymlreflects the updated prompt contract.