Removing snapshot test#38124
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
June 9, 2026 14:02
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a snapshot-based Vitest case from the validate_secrets JavaScript test suite.
Changes:
- Deleted the
generateMarkdownReport matches snapshottest fromvalidate_secrets.test.cjs.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/validate_secrets.test.cjs | Removes the only snapshot-based test for generateMarkdownReport. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
287
to
291
| expect(report).toContain("(2 tests)"); | ||
| expect(report).toContain("GitHub REST API"); | ||
| expect(report).toContain("GitHub GraphQL API"); | ||
| }); | ||
|
|
||
| it("generateMarkdownReport matches snapshot", () => { | ||
| vi.useFakeTimers(); | ||
| vi.setSystemTime(new Date("2024-01-15T12:00:00.000Z")); | ||
| try { | ||
| const results = [ | ||
| { secret: "GH_AW_GITHUB_TOKEN", test: "REST API", status: "failure", message: "401" }, | ||
| { secret: "ANTHROPIC_API_KEY", test: "Anthropic", status: "not_set", message: "not set" }, | ||
| { secret: "BRAVE_API_KEY", test: "Brave", status: "success", message: "OK" }, | ||
| ]; | ||
| expect(generateMarkdownReport(results)).toMatchSnapshot(); | ||
| } finally { | ||
| vi.useRealTimers(); | ||
| } | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent