Skip to content

Harden validate-yaml release-build lockfile detection in CGO workflow #38112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Jun 9, 2026
+249 −95
Merged

Harden validate-yaml release-build lockfile detection in CGO workflow #38112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb56715
Initial plan
Copilot Jun 9, 2026
1e6cb80
chore: start investigating validate-yaml workflow failure
Copilot Jun 9, 2026
d7429d7
fix: harden cgo lock-file release marker detection
Copilot Jun 9, 2026
5eac015
refactor: simplify cgo release-marker check logic
Copilot Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/cgo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,17 +520,20 @@ jobs:
# Track if any release-compiled files are found
FOUND_RELEASE=0

# Check each file for version numbers in the header
# Check each file for release-build markers.
# Release builds include version like: "# This file was automatically generated by gh-aw (v1.0.0). DO NOT EDIT."
# Dev builds do not: "# This file was automatically generated by gh-aw. DO NOT EDIT."
for file in $LOCK_FILES; do
# Look for the pattern: "by gh-aw (v" or "by gh-aw (0" or similar version patterns
# This matches versions like (v1.0.0), (0.1.0), etc.
if grep -E '# This file was automatically generated by gh-aw \([v0-9]' "$file" > /dev/null 2>&1; then
# Release-compiled lock files can be identified by either:
# 1. Header marker with version suffix (legacy): "...generated by gh-aw (vX.Y.Z)."
# 2. Metadata marker: compiler_version field in gh-aw-metadata.
HEADER_MARKER=$(grep -E '^# This file was automatically generated by gh-aw \([v0-9]' "$file" || true)
METADATA_MARKER=$(grep -E '^# gh-aw-metadata: .*"compiler_version":' "$file" || true)
if [ -n "$HEADER_MARKER$METADATA_MARKER" ]; then
echo "❌ ERROR: Found release-compiled lock file: $file"
echo ""
echo "Header line:"
grep -E '# This file was automatically generated by gh-aw \([v0-9]' "$file" || true
echo "Release-build marker(s):"
printf '%s\n%s\n' "$HEADER_MARKER" "$METADATA_MARKER" | sed '/^$/d'
echo ""
FOUND_RELEASE=1
fi
Expand All @@ -541,7 +544,7 @@ jobs:
echo "💡 Lock files should NOT be compiled with a release build!"
echo ""
echo "Lock files in the repository must be compiled with development builds."
echo "Release builds include version numbers in the header, which should only"
echo "Release builds include version markers (header or metadata), which should only"
echo "appear in released binaries, not in source-controlled workflow files."
echo ""
echo "To fix:"
Expand All @@ -555,7 +558,7 @@ jobs:
exit 1
fi

echo "✅ All lock files compiled with development build (no version in header)"
echo "✅ All lock files compiled with development build (no release markers)"

- name: Check skill file URLs use main branch
run: |
Expand Down
Loading