Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compact generated system prompt blocks by flattening XML wrappers and removing duplicated guidance #38049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Compact generated system prompt blocks by flattening XML wrappers and removing duplicated guidance #38049
Changes from 1 commit
84b2c21ccf28e480b32257c9dba4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/zoom-out] The
<file-editing>/<allowed-paths>block — including "Do NOT attempt to edit files outside these directories as you do not have the necessary permissions" — was removed with no replacement. The PR description calls these "empty/unused nested blocks", but this block carried real instructional text.The malformed XML (missing
</allowed-paths>closing tag) and absent concrete paths make its practical value limited, so removal could be intentional. Worth confirming: is this file-editing constraint now redundant with OS-level enforcement, or should a plain-text equivalent be added alongside the<environment-limitations>block?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot revert all .go changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted —
cache.go,cache_memory_integration_test.go,cache_memory_prompt_test.go, andprompts_test.goare back to their state before the previous fix commit.Uh oh!
There was an error while loading. Please reload this page.