Skip to content

Allow AWF CLI proxy traffic to host DIFC port in gh-proxy workflows#37972

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/aw-fix-pr-sous-chef-failure-again
Closed

Allow AWF CLI proxy traffic to host DIFC port in gh-proxy workflows#37972
Copilot wants to merge 3 commits into
mainfrom
copilot/aw-fix-pr-sous-chef-failure-again

Conversation

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR Sous Chef failed before agent startup because the AWF awf-cli-proxy sidecar could not reach the external DIFC proxy (host.docker.internal:18443). This change updates AWF host-port generation for tools.github.mode: gh-proxy so the CLI proxy path is permitted.

  • Root cause addressed

    • In gh-proxy mode, AWF was launched with --difc-proxy-host host.docker.internal:18443 but host port allowlisting did not include 18443, causing sidecar startup failure.
  • Compiler/AWF argument changes

    • Updated BuildAWFArgs to append 18443 to --allow-host-ports when GitHub CLI mode is enabled.
    • Preserved existing behavior for MCP gateway host ports and avoided duplicate 18443 when MCP port is already 18443.
    • Clarified logging text to reflect both MCP gateway and CLI proxy host access.
  • Coverage updates

    • Added focused unit coverage for host-port composition in gh-proxy mode.
    • Updated the impacted wasm golden fixture (pi.golden) to match emitted AWF args.
# Before (gh-proxy workflows)
--allow-host-ports 80,443,8080 --difc-proxy-host host.docker.internal:18443

# After
--allow-host-ports 80,443,8080,18443 --difc-proxy-host host.docker.internal:18443

Copilot AI linked an issue Jun 8, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits June 9, 2026 00:11
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug and fix PR Sous Chef workflow failure Allow AWF CLI proxy traffic to host DIFC port in gh-proxy workflows Jun 9, 2026
Copilot AI requested a review from pelikhan June 9, 2026 00:18
@pelikhan pelikhan added the awf label Jun 9, 2026
@pelikhan

pelikhan commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

@lpcox

@pelikhan pelikhan closed this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] PR Sous Chef failed

2 participants