-
Notifications
You must be signed in to change notification settings - Fork 3
Use cluster endpoint at startup #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
piceri
wants to merge
11
commits into
main
Choose a base branch
from
piceri/startup-cluster-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bceccaf
add logic to process syncEvents, prevent sync events from entering queue
piceri 9fbb433
add PostCluster to client
piceri 6279e19
add logic to fillCaches after PostCluster
piceri 85e4e6e
enable partial success, refactors and improvements
piceri 1e60f34
add tests for processSyncEvents
piceri 92408e4
add tests for PostCluster
piceri a48254e
update url variable names
piceri 3bfff1a
refactor record.go, address linting items
piceri 6e22407
add logging and comments
piceri 3ed17e1
adjust syncRecords to include terminated jobs
piceri 7757dfe
add logging to non-rate limit 4xx responses
piceri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ import ( | |
| "fmt" | ||
| "log/slog" | ||
| "strings" | ||
| "sync/atomic" | ||
| "time" | ||
|
|
||
| "github.com/github/deployment-tracker/internal/metadata" | ||
|
|
@@ -47,7 +48,8 @@ type ttlCache interface { | |
| } | ||
|
|
||
| type deploymentRecordPoster interface { | ||
| PostOne(ctx context.Context, record *deploymentrecord.DeploymentRecord) error | ||
| PostOne(ctx context.Context, record *deploymentrecord.Record) error | ||
| PostCluster(ctx context.Context, records []*deploymentrecord.Record, cluster string) ([]byte, error) | ||
| } | ||
|
|
||
| type podMetadataAggregator interface { | ||
|
|
@@ -87,6 +89,7 @@ type Controller struct { | |
| // informerSyncTimeout is the maximum time allowed for all informers to sync | ||
| // and prevents sync from hanging indefinitely. | ||
| informerSyncTimeout time.Duration | ||
| syncing atomic.Bool | ||
| } | ||
|
|
||
| // New creates a new deployment tracker controller. | ||
|
|
@@ -147,10 +150,16 @@ func New(clientset kubernetes.Interface, metadataAggregator podMetadataAggregato | |
| unknownArtifacts: amcache.NewExpiring(), | ||
| informerSyncTimeout: informerSyncTimeoutDuration, | ||
| } | ||
| cntrl.syncing.Store(true) | ||
|
|
||
| // Add event handlers to the informer | ||
| _, err = podInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{ | ||
| AddFunc: func(obj any) { | ||
| // Skip adding sync events | ||
| if cntrl.syncing.Load() { | ||
| return | ||
| } | ||
|
Comment on lines
158
to
+162
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think these events should still be captured. I will adjust the PR description. |
||
|
|
||
| pod, ok := obj.(*corev1.Pod) | ||
| if !ok { | ||
| slog.Error("Invalid object returned", | ||
|
|
@@ -314,6 +323,12 @@ func (c *Controller) Run(ctx context.Context, workers int) error { | |
| return errors.New("timed out waiting for caches to sync - please ensure deployment tracker has the correct kubernetes permissions") | ||
| } | ||
| } | ||
| c.syncing.Store(false) | ||
| syncClusterPods := c.podInformer.GetIndexer().List() | ||
| err := c.processSyncEvents(ctx, syncClusterPods) | ||
| if err != nil { | ||
| return fmt.Errorf("sync events failed: %w", err) | ||
| } | ||
|
|
||
| slog.Info("Starting workers", | ||
| "count", workers, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.