Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ jobs:
run: npm ci
- name: Check contributions requirements
run: npm run test-contrib
env:
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
- name: Run linter
run: npm run linter

Expand Down
14 changes: 6 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ Before working on something, ensure that it will not duplicate any active open p

It is advised to open a [`💬 discussion`](https://github.com/gh-metrics/metrics/discussions) first to gather feedback about new features.

> ⚠️ To avoid an ever-growing backlog, inactive pull requests will be closed after 3 weeks and locked after 5 weeks.

> 😅 Be positive! Even if your changes don't get merged in [gh-metrics/metrics](https://github.com/gh-metrics/metrics), please don't be too sad, you will always be able to run workflows directly from your fork!

## 🤝 Accepted contributions
Expand Down Expand Up @@ -70,21 +68,21 @@ The following contributions are accepted:
<tr>
<td nowrap="nowrap">🧱 Core</td>
<td>✓</td>
<td></td>
<td></td>
<td>
<ul>
<li>Core changes impact all rendering process and should be avoided unless necessary</li>
<li>New dependencies should be avoided when possible</li>
<li>Core changes impact all rendering process, so extra care is needed</li>
<li>New dependencies should be avoided unless necessary</li>
</ul>
</td>
</tr>
<tr>
<td nowrap="nowrap">🗃️ Repository</td>
<td></td>
<td></td>
<td></td>
<td></td>
<td>
<ul>
<li>Workflows, license, readmes, etc. usually don't need to be edited</li>
<li>Workflows, license, readmes, etc. usually don't need to be edited often</li>
</ul>
</td>
</tr>
Expand Down
21 changes: 0 additions & 21 deletions tests/ci.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,6 @@ describe("Check file changes (checkout your files if needed)", () => {
".github/workflows/examples.yml",
".github/readme/partials/documentation/compatibility.md",
])("%s", async file => expect((await diff()).includes(file)).toBe(false)))
if (!["gh-metrics"].includes(process.env.PR_AUTHOR)) {
describe("Repository level files were not modified", () =>
void test.each([
".github/config/*",
".github/ISSUE_TEMPLATE/*",
".github/readme/partials/license.md",
".github/scripts/*",
".github/workflows/*",
".github/architecture.svg",
".github/dependabot.yml",
".github/FUNDING.yml",
".github/pull_request_template.md/*",
"LICENSE",
"ARCHITECTURE.md",
"SECURITY.md",
"tests/ci.test.js",
"source/.eslintrc.yml",
"source/app/mocks/.eslintrc.yml",
"vercel.json",
])("%s", async file => expect((await diff()).filter(edited => new RegExp(`^${file.replace(/[.]/g, "[.]").replace(/[*]/g, "[\\s\\S]*")}$`).test(edited)).length).toBe(0)))
}
})

//Template changes
Expand Down