Skip to content

refactor: v4#1

Open
lishaduck wants to merge 121 commits into
v4from
v4-dev
Open

refactor: v4#1
lishaduck wants to merge 121 commits into
v4from
v4-dev

Conversation

@lishaduck

Copy link
Copy Markdown
Member

I'm not going to pretend like I've got lots of time to resume lowlighter#1542, but I'd at least like to make sure it doesn't get lost to the stale bot.

@lishaduck

Copy link
Copy Markdown
Member Author

Tests are throwing lots of errors, but they pass!?


// Search for specific filename
// deno-lint-ignore no-constant-condition
if (false) {

Check warning

Code scanning / CodeQL

Unreachable statement

This statement is unreachable.

// Search for specific extension
// deno-lint-ignore no-constant-condition
if (false) {

Check warning

Code scanning / CodeQL

Unreachable statement

This statement is unreachable.
// Pull request created
case "PullRequestEvent": {
return null
if (!["opened", "edited", "closed", "reopened", "assigned", "unassigned"].includes(payload.action)) {

Check warning

Code scanning / CodeQL

Unreachable statement

This statement is unreachable.
// Release published
case "ReleaseEvent": {
return null
if (payload.action !== "published") {

Check warning

Code scanning / CodeQL

Unreachable statement

This statement is unreachable.
parsed[key] ??= value
{
const k = yaml({ [key]: null }, { inline: true }).match(kv)?.groups?.key.trim()
const a = typeof value === "undefined" ? `${value}` : yaml({ [key]: value }, { inline: true }).match(kv)?.groups?.value.trim()

Check warning

Code scanning / CodeQL

Implicit operand conversion

This expression will be implicitly converted from undefined to string.
@chickenandpork

This comment was marked as off-topic.

@lishaduck

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants