Skip to content

fix(release-bubbles): guard against disposed echartsInstance in mouse handlers #119471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billyvg wants to merge 1 commit into from
Closed

fix(release-bubbles): guard against disposed echartsInstance in mouse handlers #119471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions static/app/views/explore/releases/releaseBubbles/useReleaseBubbles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export function useReleaseBubbles({
const highlightedBuckets = new Set();

const handleMouseMove = (params: ElementEvent) => {
if (!echartsInstance) {
if (!echartsInstance || echartsInstance.isDisposed()) {
return;
}

Expand Down Expand Up @@ -509,7 +509,7 @@ export function useReleaseBubbles({
};

const handleMouseOver = (params: Parameters<EChartMouseOverHandler>[0]) => {
if (params.seriesId !== BUBBLE_SERIES_ID || !echartsInstance) {
if (params.seriesId !== BUBBLE_SERIES_ID || !echartsInstance || echartsInstance.isDisposed()) {
return;
}

Expand Down Expand Up @@ -544,7 +544,7 @@ export function useReleaseBubbles({
};

const handleMouseOut = (params: Parameters<EChartMouseOutHandler>[0]) => {
if (params.seriesId !== BUBBLE_SERIES_ID || !echartsInstance) {
if (params.seriesId !== BUBBLE_SERIES_ID || !echartsInstance || echartsInstance.isDisposed()) {
return;
}

Expand All @@ -563,7 +563,7 @@ export function useReleaseBubbles({
// (i.e. bottom of chart), the bubble will remain highlighted. This makes it
// look buggy and can be misleading especially for bubbles w/ 0 releases.
const handleGlobalOut = () => {
if (!echartsInstance) {
if (!echartsInstance || echartsInstance.isDisposed()) {
return;
}

Expand Down
Loading