fix(detectors): Guard against null queryObj in cron monitor list#119445
Closed
sentry[bot] wants to merge 1 commit into
Closed
fix(detectors): Guard against null queryObj in cron monitor list#119445sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedNon-null assertions (
This is informational only and does not block the PR. |
Member
|
This is more of a data integrity issue, so it's better that we delete the offending models and prevent the data from being corrupted instead. Making this an optional field isn't really correct and it will cause the code to be much more gnarly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
TypeError: Cannot read properties of null (reading 'environments')that occurred in the cron monitor list (/monitors/crons/).The root cause was that the API could return a
CronDetectorobject wheredataSources[0].queryObjwasnull, even though the TypeScript typeCronMonitorDataSourcedeclaredqueryObjas non-nullable. This led to a runtime crash when accessing properties likeenvironmentson a nullqueryObj.The fix involves:
CronMonitorDataSourcetype instatic/app/types/workflowEngine/detectors.tsxto correctly reflect thatqueryObjcan benull.?.) and null guards instatic/app/views/detectors/list/cron.tsxfor all accesses toqueryObjand its properties, specifically in theVisualizationCelland theenvironment-labelcolumn'srenderCellfunction. This ensures the UI gracefully handles cases wherequeryObjis null without crashing.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-39QF
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.