chore(workflow-engine): Enable activity alerts for resolution#119359
Open
leeandher wants to merge 1 commit into
Open
chore(workflow-engine): Enable activity alerts for resolution#119359leeandher wants to merge 1 commit into
leeandher wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
approved these changes
Jul 9, 2026
saponifi3d
left a comment
saponifi3d
left a comment
Contributor
There was a problem hiding this comment.
lgtm - the feature flag recommendation is mostly a nice to have in case we want to roll back or slow the rollout to just sentry to confirm the experience first.
Comment on lines
+23
to
+26
| ActivityType.SET_RESOLVED.value: NotificationSource.ACTIVITY_SET_RESOLVED, | ||
| ActivityType.SET_RESOLVED_IN_RELEASE.value: NotificationSource.ACTIVITY_SET_RESOLVED_IN_RELEASE, | ||
| ActivityType.SET_RESOLVED_BY_AGE.value: NotificationSource.ACTIVITY_SET_RESOLVED_BY_AGE, | ||
| ActivityType.SET_RESOLVED_IN_COMMIT.value: NotificationSource.ACTIVITY_SET_RESOLVED_IN_COMMIT, |
Contributor
There was a problem hiding this comment.
since there's a little concern around functionality and possible duplication of notifications here, can we wrap adding these to the ACTIVITY_TYPE_TO_SOURCE with a feature flag?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a bit of sneaking suspicion that because the default alert builder has "An issue is resolved" as a trigger, a lot of people have channels set up to receive these notifications that have been failing silently this whole time.
Since they'll be turned on now, I wanted to break out the enablement into its own PR from rendering in case we need to revert or something. The other PR had some unrelated refactors so this keeps it a bit simpler to revert-revert and review.
Also per the discussion on the last PR, I will changing all the
NotificationDatatypes to simplify them quite a bit as a part of a separate ticket: https://linear.app/getsentry/issue/ISWF-2996/refactor-away-from-model-references-in-notificationdata