build(npm): Set publishConfig.tag=v8.14 on 8.14.x packages#6454
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
alwx
marked this pull request as ready for review
July 15, 2026 20:46
npm 11 refuses to implicitly bump `latest` to a lower version, so publishing 8.14.2 (with `latest` at 8.18.0) needs an explicit dist-tag. Set `publishConfig.tag: "v8.14"` directly on both publishable packages so npm itself picks it up regardless of what craft passes on the CLI. The craft-side `checkPackageName` fix (previous PR) is still valid belt-and-suspenders, but the retry after it landed still failed with the same npm error and craft's expected "Adding tag ..." warn never appeared in the log — this is the pragmatic fallback that unblocks the 8.14.2 publish immediately. `v8.14` reads better than the generic `old` and namespaces future 8.14.x hotfixes to the same tag. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alwx
force-pushed
the
alwx/backport/8.14-publishconfig-tag
branch
from
July 16, 2026 06:24
287eb77 to
6934953
Compare
alwx
changed the title
romtsn
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add
"tag": "v8.14"underpublishConfigin both publishable package.json files (@sentry/react-native,@sentry/expo-upload-sourcemaps). npm reads that at publish time and uses it as the default dist-tag when no--tagis passed on the CLI.💡 Motivation and Context
Prior PR set craft's
checkPackageNameso craft would pass--tag=oldautomatically. That merged, but the retry still failed with the sameCannot implicitly apply the "latest" tagerror — and craft's expectedAdding tag ...warn never showed up in the run log. Something in the runtime path is preventinggetPublishTagfrom doing its job here.publishConfig.tagis a standard npm feature and bypasses the craft config path entirely, so it unblocks the 8.14.2 publish regardless.v8.14reads better than the genericoldand namespaces future 8.14.x hotfixes to the same tag.Failing run: https://github.com/getsentry/publish/actions/runs/29435125643/job/87419718179
💚 How did you test it?
Config-only change. Verified by re-running the craft publish job after merge.
📝 Checklist