feat(android): Add enableHistoricalTombstoneReporting option#6450
Open
Cryptoteep wants to merge 2 commits into
Open
feat(android): Add enableHistoricalTombstoneReporting option#6450Cryptoteep wants to merge 2 commits into
Cryptoteep wants to merge 2 commits into
Conversation
Expose sentry-java's reportHistoricalTombstones (introduced in 8.48.0) as a JS init option, mirroring the existing enableTombstone wiring. iOS is a no-op. Closes getsentry#6423 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Adds a new JS init option
enableHistoricalTombstoneReportingthat maps toSentryAndroidOptions.setReportHistoricalTombstones(...)on Android, mirroring the existingenableTombstonewiring inRNSentryStart.getSentryAndroidOptions. iOS is a no-op.The option only has an effect when
enableTombstoneistrue(same gating as in sentry-java'sTombstoneIntegration), which is called out in the TSDoc.💡 Motivation and Context
Closes #6423
sentry-java
8.48.0(already the pinned version in this repo) introduced historical tombstone reporting, but RN users currently have to set theio.sentry.tombstone.report-historical<meta-data>inAndroidManifest.xmlby hand. This brings the toggle to the JS layer for parity withenableTombstone.💚 How did you test it?
Added three unit tests in
RNSentryStartTest.kt(true / false / unset-default), mirroring the existingenableTombstonetests.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
If the docs team wants it, a follow-up to document the option on docs.sentry.io.
🤖 Generated with Claude Code