fix(e2e): Retry iOS E2E flows when app fails to reach "E2E Tests Ready"#6448
Merged
Conversation
On Cirrus Labs Tart VMs, roughly one `maestro test` flow per run of `e2e-v2.yml` on iOS intermittently fails immediately after `launchApp clearState` with `Assert that "E2E Tests Ready" is visible... FAILED`. The failure duration (14-19s) is far below the 5-minute `extendedWaitUntil` in `assertTestReady.yml`, indicating the Maestro driver or app connection drops on the fresh launch rather than a real UI regression. Retry the flow once, but only when the failure output matches this specific signature — real assertion failures elsewhere (e.g. `assertEventIdVisible`, `App crashed`) are surfaced immediately so regressions are not masked. Maestro's CLI exit code is a flat 0/1 (`TestCommand.kt:461`), so the pattern must be detected in stdout. The retry logs a distinct `[Flaky] ... — retrying (2/2)` line and a `(attempt 2/2)` suffix on the passing line so CI output makes it obvious when the flake occurred. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 25971c9. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The `else` branch handling a non-retryable failure logged `[Failed]` but did not exit the inner `for (attempt)` loop, so a real failure (anything without the `E2E Tests Ready` flake signature) would still run `maestro test` a second time. That contradicts the "surface regressions immediately" invariant this retry logic was written to preserve — if the second attempt happened to pass, a real regression would be silently masked. Caught by both Cursor Bugbot and Sentry's autofix reviewer. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 411.11 ms | 454.38 ms | 43.27 ms |
| d2eadf8+dirty | 414.64 ms | 454.56 ms | 39.92 ms |
| b0d3373+dirty | 557.66 ms | 579.42 ms | 21.76 ms |
| 27d9693+dirty | 419.08 ms | 469.12 ms | 50.04 ms |
| 4e0b819+dirty | 420.56 ms | 470.08 ms | 49.52 ms |
| 9474ead+dirty | 411.45 ms | 446.80 ms | 35.35 ms |
| 0bd8916+dirty | 412.77 ms | 451.31 ms | 38.54 ms |
| f9c1ed4+dirty | 431.00 ms | 466.22 ms | 35.22 ms |
| 3d536d1+dirty | 524.34 ms | 547.32 ms | 22.98 ms |
| 04207c4+dirty | 459.19 ms | 518.54 ms | 59.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| d2eadf8+dirty | 48.30 MiB | 53.48 MiB | 5.18 MiB |
| b0d3373+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| 27d9693+dirty | 49.74 MiB | 55.09 MiB | 5.34 MiB |
| 4e0b819+dirty | 49.74 MiB | 54.81 MiB | 5.07 MiB |
| 9474ead+dirty | 48.30 MiB | 53.61 MiB | 5.30 MiB |
| 0bd8916+dirty | 48.30 MiB | 53.57 MiB | 5.26 MiB |
| f9c1ed4+dirty | 49.74 MiB | 54.86 MiB | 5.12 MiB |
| 3d536d1+dirty | 49.74 MiB | 55.26 MiB | 5.52 MiB |
| 04207c4+dirty | 43.75 MiB | 48.12 MiB | 4.37 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a50b33d+dirty | 353.21 ms | 398.48 ms | 45.27 ms |
| d038a14+dirty | 405.08 ms | 444.36 ms | 39.28 ms |
| 68672fc+dirty | 407.55 ms | 442.96 ms | 35.41 ms |
| ad66da3+dirty | 411.49 ms | 449.38 ms | 37.89 ms |
| f170ec3+dirty | 505.96 ms | 551.88 ms | 45.92 ms |
| 27d9693+dirty | 438.63 ms | 514.08 ms | 75.46 ms |
| 41d6254+dirty | 406.20 ms | 445.52 ms | 39.32 ms |
| 68ae91b+dirty | 515.04 ms | 578.08 ms | 63.04 ms |
| 5ee78d6+dirty | 411.18 ms | 437.83 ms | 26.65 ms |
| ae37560+dirty | 428.96 ms | 456.86 ms | 27.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a50b33d+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| d038a14+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| 68672fc+dirty | 48.30 MiB | 53.61 MiB | 5.31 MiB |
| ad66da3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| f170ec3+dirty | 48.30 MiB | 53.57 MiB | 5.26 MiB |
| 27d9693+dirty | 49.74 MiB | 55.09 MiB | 5.34 MiB |
| 41d6254+dirty | 48.30 MiB | 53.60 MiB | 5.30 MiB |
| 68ae91b+dirty | 49.74 MiB | 54.79 MiB | 5.05 MiB |
| 5ee78d6+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| ae37560+dirty | 48.30 MiB | 53.60 MiB | 5.29 MiB |
lucas-zimerman
approved these changes
Jul 14, 2026
lucas-zimerman
left a comment
lucas-zimerman
left a comment
Collaborator
There was a problem hiding this comment.
LGMT! after CI test pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Wrap the per-flow
maestro testinvocation indev-packages/e2e-tests/cli.mjswith a one-shot retry, but only for the specific Cirrus Labs Tart VM flake where the app fails to render "E2E Tests Ready" after a freshlaunchApp clearState.Behavior:
MAX_ATTEMPTS = 2— at most one retry per flow.Assert that "E2E Tests Ready" is visible... FAILED. Every other failure (real assertion failure likeassertEventIdVisible,App crashed, driver errors) still fails immediately, so regressions are not masked.[Flaky] <name> (Xs) (Assert that "E2E Tests Ready" is visible... FAILED) — retrying (2/2)[Passed] <name> (Xs) (attempt 2/2)Everything lives inside
cli.mjs;.github/workflows/e2e-v2.ymlis unchanged.💡 Motivation and Context
Over the last week, the
Test RN 0.86.0 ... hermes ios production no on cirrusE2E jobs onmainhave failed on most non-trivial pushes.Every failure is the same shape:
💚 How did you test it?
node --check dev-packages/e2e-tests/cli.mjs— syntax valid.main; every one contains the retried string on a launch afterkillApp, not on an in-test assertion.mainmerges.📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
main— if the[Flaky] ... — retryingline becomes rare enough or a specific flow starts consistently failing on retry too, the underlying Cirrus/Tart-VM issue can be revisited (e.g. shutting down and rebooting the simulator between flows, or moving primary runs to Bitrise).🤖 Generated with Claude Code
#skip-changelog