[WIP] feat(feedback): Add SentryEvent.get_feedback() - #883
Open
limbonaut wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
before_send_feedbackcallback receives the prepared feedback event, but the fields the user submitted, the message, name, contact email, and associated event id, sit in that event'sfeedbackcontext, which had no getter. A callback could discard the feedback or tag it, but could not read or scrub what was typed short of inspectingto_json(), and had no way to write anything back. This PR addsSentryEvent.get_feedback(), which returns the feedback as a live view of the event: reading it gives back what the user submitted, and writing to it modifies the event before it is sent. It returns null for events that carry no feedback, including the ones reachingbefore_send. iOS and macOS are the exception, sincebefore_send_feedbackis not implemented there yet.