feat(apple): Integrate SentryObjC framework and add metrics support - #755
Merged
Conversation
This was referenced Jun 10, 2026
Closed
limbonaut
marked this pull request as ready for review
June 17, 2026 13:49
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 70cd06d. Configure here.
limbonaut
commented
Jun 22, 2026
| String key = keys[i]; | ||
| set_attribute(key, p_attributes[key]); | ||
| const Variant &key = keys[i]; | ||
| set_attribute(key.stringify(), p_attributes[key]); |
Collaborator
Author
There was a problem hiding this comment.
FYI: Fixed the same bug in JS implementation too (it was flagged by Seer).
limbonaut
changed the title
Contributor
|
6 tasks
Collaborator
Author
limbonaut
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 22, 2026
Place the Metrics Options section directly after Logging Options, before the Godot Logger Options, so the structured logs and metrics feature sections sit together. Refs getsentry/sentry-godot#755 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
limbonaut
force-pushed
the
feat/sentryobjc-sdk-integration
branch
from
June 22, 2026 13:10
a2cb752 to
e2bbd11
Compare
limbonaut
requested review from
JoshuaMoelans,
bitsandfoxes,
mujacica and
tustanivsky
June 22, 2026 14:17
mujacica
approved these changes
Jun 22, 2026
limbonaut
force-pushed
the
feat/sentryobjc-sdk-integration
branch
from
June 23, 2026 10:02
1e9ef53 to
ab616ab
Compare
tustanivsky
approved these changes
Jun 23, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate SentryObjC wrapper SDK replacing previous
Sentry-Dynamic.xcframeworkCocoa integration, and implement Metrics support on Apple platforms. Also promote Metrics to GA. And fix potential silent attribute data loss across all backends by looking up dictionary values with the original Variant key.Blockers in the upstream