Skip to content

Add rel="me" to notmyproblem theme base file to support verification of identity on social media#3567

Open
castle-giant wants to merge 2 commits into
getpelican:mainfrom
castle-giant:main
Open

Add rel="me" to notmyproblem theme base file to support verification of identity on social media#3567
castle-giant wants to merge 2 commits into
getpelican:mainfrom
castle-giant:main

Conversation

@castle-giant

Copy link
Copy Markdown

…on on social media, web signin, etc

Pull Request Checklist

Resolves: #issue-number-here

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@castle-giant

Copy link
Copy Markdown
Author

I don't know anything about github so if I need to do something please let me know.

@justinmayer justinmayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @castle-giant. Thank you for the submission. I noticed an extra quotation mark that should be fixed, but otherwise this looks good. Would you correct that so I can merge your contribution?


{% for name, link in SOCIAL %}
<li><a href="{{ link }}">{{ name }}</a></li>
<li><a href="{{ link }}" rel=""me">{{ name }}</a></li>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is an extra quotation mark here that should be removed.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants