feat: add lightning fees widget to dashboard#2385
Draft
reneaaron wants to merge 1 commit into
Draft
Conversation
Adds a GET /api/transactions/stats endpoint that aggregates settled outgoing payments (excluding self-payments) into total volume, total fees paid, and payment count. The new FeeRateWidget on the home dashboard surfaces a volume-weighted average fee rate to highlight how cheap lightning payments are, hidden until there is payment volume.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Lightning fees widget to the home dashboard to highlight how cheap lightning payments are.
GET /api/transactions/statsendpoint aggregating settled outgoing payments intototalVolume,totalFeesPaid, andnumPayments(self-payments excluded — they never traverse the network and would dilute the rate toward zero).FeeRateWidgetrenders a volume-weighted average fee rate (fees ÷ volume) plus a one-line supporting sentence. Hidden until there's payment volume, so it never shows a hollow0%to brand-new users.<0.01%formatting for tiny rates.Screenshots
Notes
WHEREis index-assisted (state, type) so it won't full-table-scan, butamount_msat/fee_msataren't indexed, so each matching row is fetched for theSUM. Fine for typical hubs (thousands of payments); a code comment documents adding a covering indextransactions(type, state, self_payment, amount_msat, fee_msat)before this needs to scale to millions. This is already a better pattern than the existingGetForwardswidget, which loads all rows into memory.SUM/COUNT, no DB-specific percentile — chose a weighted rate over avg/median deliberately).Test plan
go test ./api/ -run TestGetTransactionStats— verifies the sums and that pending/incoming/self-payment rows are excluded, plus the empty case.go build ./..., frontendtsc+ eslint + prettier clean.