feat(cql2): align temporal predicates with CQL2 spec#155
Open
constantinius wants to merge 1 commit into
Open
Conversation
Map CQL2 spec operator names to existing AST types without renaming them, keeping all other parsers and backends unaffected. - Use spec names in TEMPORAL_PREDICATES_MAP: t_starts → TimeBegins, t_startedBy → TimeBegunBy, t_finishes → TimeEnds, t_finishedBy → TimeEndedBy (camelCase keys per JSON schema) - Add TimeIntersects AST node — t_intersects was incorrectly aliased to TimeOverlaps - Add t_disjoint mapping (AST node TimeDisjoint already existed) - Change text syntax from infix (a T_BEFORE b) to function-call T_BEFORE(a, b) per spec BNF - Expand INTERVAL to accept DATE strings and open-ended '..' params
constantinius
force-pushed
the
cql2-temporal-compliance
branch
from
6a08292 to
85b862d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the CQL2 Temporal conformance class with the OGC 21-065r2 spec.
Maps CQL2 spec operator names to existing AST types without renaming them, keeping all other parsers and backends unaffected.
Changes
t_starts→TimeBegins,t_startedBy→TimeBegunBy,t_finishes→TimeEnds,t_finishedBy→TimeEndedByinTEMPORAL_PREDICATES_MAPt_metBy,t_overlappedBy,t_startedBy,t_finishedBy)TimeIntersectsAST node — was incorrectly aliased toTimeOverlapsa T_BEFORE bto function-callT_BEFORE(a, b)per spec BNF'..'parameters per specDesign decision
The existing AST types (
TimeBegins,TimeEnds, etc.) are preserved as-is. The CQL2 layer maps spec names to them without requiring changes to FES, ECQL, or any backend.Spec reference
OGC 21-065r2 §6.9