fix(cql2-json): CQL2 Advanced Comparison conformance fixes#154
Open
constantinius wants to merge 1 commit into
Open
fix(cql2-json): CQL2 Advanced Comparison conformance fixes#154constantinius wants to merge 1 commit into
constantinius wants to merge 1 commit into
Conversation
- BETWEEN: switch to flat 3-arg format [lhs, low, high] in both parser and
encoder, matching OGC CQL2 spec (previously used nested [lhs, [low, high]])
- NOT flags: wrap like/between/in_ results in {"op": "not", "args": [...]}
when node.not_ is True, matching behavior of isNull handler
- CASEI/ACCENTI: parse 'casei'/'lower' op to ast.Function('lower', ...),
'accenti' op to ast.Function('accenti', ...); encode lower->casei and
accenti->accenti using {"op": ...} format instead of non-standard
{"lower": ...}/{"upper": ...} objects
- Fix function fallback encoder to use {"op": name, "args": [...]} format
- Update test fixtures and add conformance regression tests for round-trips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the CQL2 Advanced Comparison conformance class with the OGC 21-065r2 spec.
Changes
[lhs, low, high]per spec, not nested[lhs, [low, high]](both parser and encoder){"op": "not", ...}whennot_=True(was silently dropped){"op": "casei", ...}per spec (and legacy{"lower": ...}). Encoder outputs{"op": "casei", ...}{"op": "accenti", ...}. Encoder outputs{"op": "accenti", ...}Spec reference
OGC 21-065r2 §6.7