Use HEAD request instead of GET when checking if the public URL is correct#3092
Open
miku-orb wants to merge 1 commit into
Open
Use HEAD request instead of GET when checking if the public URL is correct#3092miku-orb wants to merge 1 commit into
miku-orb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very tiny thing, but it caught my attention while looking throughout the codebase.
Using a
GETrequest here is wasteful, whileHEADis semantically the same, but allows avoiding the transfer of the actual file's body, which we don't care about when testing just if the HTTP response is 200 OK.I did test that it still works (and it has to work with any HTTP server that isn't completely broken).