Fix logo redirect URL on logo being empty href#3091
Open
miku-orb wants to merge 1 commit into
Open
Conversation
…ig.java Fixes getLogoRedirectURL() in BaseAction.java not falling back to default URL if the string was empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes getLogoRedirectURL() in BaseAction.java not falling back to default URL if the string was empty.
ipt/src/main/java/org/gbif/ipt/action/BaseAction.java
Lines 153 to 156 in b903ce0
The logo redirect URL property could be an empty string instead of null (missing),
if the logo redirect URL was previously set in admin panel, and then removed again(EDIT: it wasn't even needed to ever set it, to reproduce it's enough to just click Save on the IPT settings page).This would have resulted in empty href on the logo link in HTML:
...which would make the logo link redirect to the present page instead of home page.