Skip to content

Enable python bindings by default on windows - #804

Draft
scpeters wants to merge 3 commits into
scpeters/filter_more_test_coveragefrom
scpeters/pybind_windows_default_on
Draft

Enable python bindings by default on windows#804
scpeters wants to merge 3 commits into
scpeters/filter_more_test_coveragefrom
scpeters/pybind_windows_default_on

Conversation

@scpeters

Copy link
Copy Markdown
Member

🦟 Bug fix

Part of #472, #532

Summary

Testing python bindings on Windows to see if prior problems still occur

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Assisted-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters

Copy link
Copy Markdown
Member Author

yep, there are still test failures such as

test 131
        Start 131: Angle_TEST.py

131: Test command: C:\ProgramData\pixi\project\.pixi\envs\default\python.exe "-m" "pytest" "C:/J/workspace/gz_math-pr-cnlwin/ws/src/gz-math/src/python_pybind11/test/Angle_TEST.py" "--junitxml" "C:/J/workspace/gz_math-pr-cnlwin/ws/build/gz-math/test_results/Angle_TEST.xml"
131: Working Directory: C:/J/workspace/gz_math-pr-cnlwin/ws/build/gz-math/src/python_pybind11
131: Environment variables: 
131:  PYTHONPATH=C:/J/workspace/gz_math-pr-cnlwin/ws/build/gz-math/src/python_pybind11/test
131:  LD_LIBRARY_PATH=C:/J/workspace/gz_math-pr-cnlwin/ws/build/gz-math/src/python_pybind11/test:
131: Test timeout computed to be: 1500
131: ============================= test session starts =============================
131: platform win32 -- Python 3.12.9, pytest-8.3.5, pluggy-1.5.0
131: rootdir: C:\J\workspace\gz_math-pr-cnlwin\ws
131: plugins: colcon-core-0.19.0, cov-6.0.0, repeat-0.9.3, rerunfailures-15.0
131: collected 0 items / 1 error
131: 
131: =================================== ERRORS ====================================
131: _____ ERROR collecting src/gz-math/src/python_pybind11/test/Angle_TEST.py _____
131: ImportError while importing test module 'C:\J\workspace\gz_math-pr-cnlwin\ws\src\gz-math\src\python_pybind11\test\Angle_TEST.py'.
131: Hint: make sure your test modules/packages have valid Python names.
131: Traceback:
131: C:\ProgramData\pixi\project\.pixi\envs\default\Lib\importlib\__init__.py:90: in import_module
131:     return _bootstrap._gcd_import(name[level:], package, level)
131: ..\..\..\..\src\gz-math\src\python_pybind11\test\Angle_TEST.py:17: in <module>
131:     from gz.math import Angle
131: E   ImportError: DLL load failed while importing math: The specified module could not be found.
131: - generated xml file: C:\J\workspace\gz_math-pr-cnlwin\ws\build\gz-math\test_results\Angle_TEST.xml -
131: =========================== short test summary info ===========================
131: ERROR ..\..\..\..\src\gz-math\src\python_pybind11\test\Angle_TEST.py
131: !!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
131: ============================== 1 error in 0.22s ===============================
131/187 Test #131: Angle_TEST.py ..........................................***Failed    0.65 sec

maybe a clue in the following line:

131: E   ImportError: DLL load failed while importing math: The specified module could not be found.

@scpeters

scpeters commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

also a bunch of compiler warnings about type conversion, some of which pointed me to some non-templated types in our APIs, for example, search for double in Line2.hh, and you'll find a bunch of methods using that instead of the templated type T

here is a broader query as well

@scpeters
scpeters changed the base branch from main to scpeters/filter_more_test_coverage August 24, 2026 23:19
@scpeters
scpeters changed the base branch from scpeters/filter_more_test_coverage to main August 24, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants