Skip to content

[Dataset] ESC-50#39

Open
snkv04 wants to merge 10 commits into
galilai-group:mainfrom
snkv04:esc50-2
Open

[Dataset] ESC-50#39
snkv04 wants to merge 10 commits into
galilai-group:mainfrom
snkv04:esc50-2

Conversation

@snkv04

@snkv04 snkv04 commented Jan 30, 2026

Copy link
Copy Markdown

What does this PR do?

It implements the retrieval script for ESC-50 and tests that script.

Note: In order to use this dataset, you must have torchcodec and ffmpeg installed.

Before submitting

  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines
  • Did you write any new necessary tests?

Who can review?

@RandallBalestriero @Leon-Leyang

@Leon-Leyang

Copy link
Copy Markdown
Collaborator
  1. Could you add torchcodec and ffmpeg to pyproject.toml so that the CI tests can install them and run.
  2. Also could you run pre-commit run --all-files to pass the precommit test.

Thanks!

@snkv04

snkv04 commented Feb 6, 2026

Copy link
Copy Markdown
Author

@Leon-Leyang I did both of those, but since ffmpeg is not a pip dependency, I added it to testing.yaml instead of pyproject.toml. I'm not 100% sure if the command will work since ffmpeg was already pre-installed on Hydra so I didn't have to use the installation command, so we can see if it works when the workflow runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants