Skip to content

Add fallback to Maxbin2#8015

Open
SantaMcCloud wants to merge 8 commits into
galaxyproject:mainfrom
SantaMcCloud:update_maxbin
Open

Add fallback to Maxbin2#8015
SantaMcCloud wants to merge 8 commits into
galaxyproject:mainfrom
SantaMcCloud:update_maxbin

Conversation

@SantaMcCloud

Copy link
Copy Markdown
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

@bernt-matthias

Copy link
Copy Markdown
Contributor

Can you restore indentation (or restructure commits) such that it is easier to look at the differences.

Is it possible to add a test case covering this?

@SantaMcCloud

Copy link
Copy Markdown
Contributor Author

Can you restore indentation (or restructure commits) such that it is easier to look at the differences.

Is it possible to add a test case covering this?

You mean push a commit to revert to current version in Github and push a commit with all the chnage made by me together?

The last test is new and covert the fallback.

@bernt-matthias bernt-matthias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ment to have a commit that implements the main change without changing the indentation in the command block which makes it difficult to review.

Comment thread tools/maxbin2/maxbin2.xml
@SantaMcCloud

Copy link
Copy Markdown
Contributor Author

I ment to have a commit that implements the main change without changing the indentation in the command block which makes it difficult to review.

Ah okay now i understand it. I will make a commit only with the fallback changes so you can have a look into them!

@SantaMcCloud

Copy link
Copy Markdown
Contributor Author

@bernt-matthias i hope i did it correct if not just let me know!

Comment thread tools/maxbin2/maxbin2.xml Outdated
Comment thread tools/maxbin2/maxbin2.xml Outdated
@SaimMomin12

Copy link
Copy Markdown
Contributor

please review

@tools-iuc

tools-iuc Bot commented Jun 11, 2026

Copy link
Copy Markdown

💬 There are unresolved review comments on this PR. Please resolve them before requesting a review.

@SantaMcCloud

Copy link
Copy Markdown
Contributor Author

@SaimMomin12 should work now :)

@SaimMomin12

Copy link
Copy Markdown
Contributor

please review

@SaimMomin12

Copy link
Copy Markdown
Contributor

@paulzierep Could you assist us here in reviewing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants