Add fallback to Maxbin2#8015
Conversation
|
Can you restore indentation (or restructure commits) such that it is easier to look at the differences. Is it possible to add a test case covering this? |
You mean push a commit to revert to current version in Github and push a commit with all the chnage made by me together? The last test is new and covert the fallback. |
bernt-matthias
left a comment
There was a problem hiding this comment.
I ment to have a commit that implements the main change without changing the indentation in the command block which makes it difficult to review.
Ah okay now i understand it. I will make a commit only with the fallback changes so you can have a look into them! |
|
@bernt-matthias i hope i did it correct if not just let me know! |
|
please review |
|
💬 There are unresolved review comments on this PR. Please resolve them before requesting a review. |
|
@SaimMomin12 should work now :) |
|
please review |
|
@paulzierep Could you assist us here in reviewing? |
FOR CONTRIBUTOR:
There are two labels that allow to ignore specific (false positive) tool linter errors:
skip-version-check: Use it if only a subset of the tools has been updated in a suite.skip-url-check: Use it if github CI sees 403 errors, but the URLs work.