Skip to content

Drop syncConfigToGalaxy - #16562

Merged
dannon merged 1 commit into
galaxyproject:devfrom
davelopez:drop_sync_config_to_galaxy
Aug 17, 2023
Merged

Drop syncConfigToGalaxy#16562
dannon merged 1 commit into
galaxyproject:devfrom
davelopez:drop_sync_config_to_galaxy

Conversation

@davelopez

Copy link
Copy Markdown
Contributor

Do we still need this? smoke testing...

Potentially fixes #16559

How to test the changes?

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon

dannon commented Aug 16, 2023

Copy link
Copy Markdown
Member

My guess is likely we still need it -- we use Galaxy.config off the global object all over the place still

@davelopez

Copy link
Copy Markdown
Contributor Author

I have a bit of trouble trying to understand what this is actually doing, from what I understand, it is subscribing to changes in the config in the Galaxy.config instance and then "updating" the config in the Pinia store. But I thought the configuration is rather a static object, so this is likely not happening, or am I wrong? 🤔

@davelopez
davelopez force-pushed the drop_sync_config_to_galaxy branch from bed0a37 to e1ab601 Compare August 17, 2023 09:56
@davelopez
davelopez marked this pull request as ready for review August 17, 2023 13:01
@github-actions github-actions Bot added this to the 23.2 milestone Aug 17, 2023
@dannon

dannon commented Aug 17, 2023

Copy link
Copy Markdown
Member

@davelopez Your read of it is correct, and I just went through all occurences I could find and I think we might actually be able to do this now, which is great news. Tests are passing, so let's get it in early in the cycle here and keep our eyes open for any possible weirdness in dark corners of the app :)

I'd like to get rid of all the rxjs over time, for what it's worth.

@dannon
dannon merged commit 2d40b68 into galaxyproject:dev Aug 17, 2023
@github-actions

Copy link
Copy Markdown

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Aug 17, 2023
@davelopez
davelopez deleted the drop_sync_config_to_galaxy branch August 18, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration store bugs

3 participants