Skip to content

Fix: serialize tool_shed_urls directly from the API - #16561

Merged
mvdbeek merged 3 commits into
galaxyproject:devfrom
davelopez:fix_install_tools_from_admin_panel
Aug 17, 2023
Merged

Fix: serialize tool_shed_urls directly from the API#16561
mvdbeek merged 3 commits into
galaxyproject:devfrom
davelopez:fix_install_tools_from_admin_panel

Conversation

@davelopez

Copy link
Copy Markdown
Contributor

Fixes #16544

The tool_shed_urls are now serialized as part of the api/configuration response for Admins instead of injected later through the client controller.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions Bot added this to the 23.2 milestone Aug 16, 2023
@davelopez
davelopez force-pushed the fix_install_tools_from_admin_panel branch from 34fc5f3 to e0c102c Compare August 16, 2023 14:35
@davelopez davelopez closed this Aug 16, 2023
@davelopez davelopez reopened this Aug 16, 2023
Comment thread lib/galaxy/managers/configuration.py Outdated

@jdavcs jdavcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jdavcs

jdavcs commented Aug 16, 2023

Copy link
Copy Markdown
Member

Although test failures are relevant.

@davelopez

Copy link
Copy Markdown
Contributor Author

Although test failures are relevant.

Do you know which one? It is hard to tell with tox crashing with ROOT: HandledError| provided environments not found in configuration file

@mvdbeek

mvdbeek commented Aug 17, 2023

Copy link
Copy Markdown
Member

I bet that's tox-dev/tox#3089, which ended up in 4.9.0 released yesterday. I don't know if this is a bug or not though.

@davelopez
davelopez force-pushed the fix_install_tools_from_admin_panel branch from 6bdbf7c to f14fd25 Compare August 17, 2023 09:55
@mvdbeek
mvdbeek merged commit 1c04cd4 into galaxyproject:dev Aug 17, 2023
@davelopez
davelopez deleted the fix_install_tools_from_admin_panel branch August 17, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install and Uninstall Option missing from Admin Menu

3 participants