Skip to content

Make tool id searchable in side panel search - #16543

Merged
mvdbeek merged 1 commit into
galaxyproject:devfrom
ahmedhamidawan:add_id_to_panel_tool_search
Aug 30, 2023
Merged

Make tool id searchable in side panel search#16543
mvdbeek merged 1 commit into
galaxyproject:devfrom
ahmedhamidawan:add_id_to_panel_tool_search

Conversation

@ahmedhamidawan

Copy link
Copy Markdown
Member

Tool ids are now searchable with query: "id:sample_id" or "tool_id:sample_id". Fixes #16525

Screen.Recording.2023-08-11.at.2.19.05.PM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Tool ids are now searchable with query: "id:sample_id" or "tool_id:sample_id"
@jmchilton

Copy link
Copy Markdown
Member

This seems okay. I would... prefer that we just include the ID when we do the search without needing a tag - that is how I pretty much have exclusively used this search feature in the past. But I will admit I'm a developer and not a user.

@mvdbeek
mvdbeek merged commit 9b55269 into galaxyproject:dev Aug 30, 2023
@mvdbeek

mvdbeek commented Aug 30, 2023

Copy link
Copy Markdown
Member

Thank you @ahmedhamidawan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression of tool panel search for tool id

3 participants