Scope Workflow Stores to Workflow ID - #16523
Merged
mvdbeek merged 3 commits intoAug 8, 2023
Merged
Conversation
ElectronicBlueberry
added
area/UI-UX
kind/refactoring
ElectronicBlueberry
force-pushed
the
workflow-store-scope
branch
from
August 7, 2023 12:39
61398c3 to
54dec57
Compare
mvdbeek
reviewed
Aug 7, 2023
| throw new Error("WorkflowId is undefined"); | ||
| } | ||
|
|
||
| return defineStore(`workflowConnectionStore${workflowId}`, { |
Member
There was a problem hiding this comment.
Nice solution! Is this documented somewhere as a pattern for scoping stores ?
Member
Author
There was a problem hiding this comment.
I found the concept here: vuejs/pinia#840 (comment)
Seems to work very well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the workflow stores to be scoped, in preparation for enabling to use multiple instances of the workflow editor simultaneously.
Relevant comment: #16510 (comment)
How to test the changes?
(Select all options that apply)
License