Vueify Data Uploader - #16472
Merged
Merged
Conversation
guerler
added
kind/enhancement
area/UI-UX
kind/refactoring
guerler
force-pushed
the
uploader_default_mixin
branch
7 times, most recently
from
August 2, 2023 06:17
178cda9 to
698442b
Compare
guerler
force-pushed
the
uploader_default_mixin
branch
19 times, most recently
from
August 7, 2023 18:01
700f993 to
cc91fbf
Compare
guerler
force-pushed
the
uploader_default_mixin
branch
2 times, most recently
from
August 12, 2023 06:53
94e6427 to
f1d2bba
Compare
guerler
force-pushed
the
uploader_default_mixin
branch
from
August 12, 2023 07:01
f1d2bba to
ecf862e
Compare
guerler
force-pushed
the
uploader_default_mixin
branch
from
August 13, 2023 06:52
9b104a4 to
7f656d8
Compare
Member
|
Really nice, thanks so much! |
Member
|
The clipping on the selecting a datatype for all uploads seems a little off. 
|
Contributor
Author
|
Thanks a lot for the review @jmchilton. I can follow-up with the selection area visibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #16407. This PR rewrites the Uploader Interface by removing Backbone and Mixins, and converting all modules to Vue's composition API. Additionally this PR removes the usage of jQuery, and replaces the Select2-field with vue-multiselect. The appearance of the user interface has only been minimally altered, except for the RulesInput builder which has been brought into alignment with other upload types. This new uploader is functionally equivalent to the existing uploader, however FTP files are selected using the Remote Files dialog, instead of the popover table. TypeScript will be applied in a follow-up.
How to test the changes?
(Select all options that apply)
License