Rewrote prerequisites section in README.md#6422
Conversation
| Before running this second command, there must be a reference to fyne in one of your project's source files. The following, works: | ||
|
|
||
| import "fyne.io/fyne/v2/app" | ||
|
|
||
| Note that: | ||
| * `import "fyne.io/fyne/v2"` does not work. |
There was a problem hiding this comment.
Perhaps the intended design of the individual fyne modules should be better explored. Mentioning @andydotxyz related to this comment #6418 (comment).
If the intended design is clearer, then this section could be rewritten before merging the pull request. Such that it is better defined whether the above is a workaround that works now, or defined behaviour that will continue to work always.
There was a problem hiding this comment.
This is going far too much into the weeds - which packages can and cannot retain a go.mod reference with no code added is unimportant - what matters is the app using fyne before they call "go mod tidy"
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
I think this is getting caught up on details that don't matter by explaining tools that the user may not be using. A clearer definition of Fyne package requirements will cause more confusion not les.
| Before running this second command, there must be a reference to fyne in one of your project's source files. The following, works: | ||
|
|
||
| import "fyne.io/fyne/v2/app" | ||
|
|
||
| Note that: | ||
| * `import "fyne.io/fyne/v2"` does not work. |
There was a problem hiding this comment.
This is going far too much into the weeds - which packages can and cannot retain a go.mod reference with no code added is unimportant - what matters is the app using fyne before they call "go mod tidy"
|
|
||
| Note that: | ||
| * `import "fyne.io/fyne/v2"` does not work. | ||
| * some tools (such as [the official Visual Studio Go extension](https://marketplace.visualstudio.com/items?itemName=golang.go)), automatically remove unused imports. In which case you'll have to also write some code that uses an imported fyne module. |
There was a problem hiding this comment.
Don't go into the details - just phrase it such that the code should use some Fyne code before calling "go mod tidy" to be ready to build.
|
@andydotxyz I addressed the feedback, how is this? |
2 participants
Description:
Fixes #6418
Checklist:
None relevant.
[ ] Tests included.[ ] Lint and formatter run with no errors.[ ] Tests all pass.