support fully rounded corner radius - #5839
Conversation
|
I don't understand this API sorry. I think it's the same as setting the radius on a rectangle to be half the width or height. |
|
Right, the API is essentially the same as setting the radius on a rectangle to be half the width or height. Originally, this approach was reserved for circles, but I wanted to extend similar functionality to rectangles as well. |
Thanks, this makes sense as a use-case. Essentially this could be called p.s. it would need to be added into the software painter as well - in this case it should be straight forward. |
Great! I will update the PR, should I also add some unit tests ? |
Yes please - always (unless not possible) |
|
I added |
andydotxyz
left a comment
There was a problem hiding this comment.
Nice one, thanks for this!
Description:
(Based on #5830)
Added a new constant
FullyRoundedCornerRadiusfor pill/circular shapes as per Material Design.Checklist:
Where applicable: