Minor cleanups to wasm driver - #5790
Merged
Merged
Conversation
andydotxyz
reviewed
Jun 16, 2025
andydotxyz
requested changes
Jul 4, 2025
andydotxyz
left a comment
andydotxyz
left a comment
Member
There was a problem hiding this comment.
Nice to get tidy-ups, but I think it cuts out code that should be fixed not removed.
| modifier := desktopModifier(mods) | ||
| var button desktop.MouseButton | ||
| rightClick := false | ||
| if runtime.GOOS == "darwin" { |
Member
There was a problem hiding this comment.
I'm not sure about removing this code - although it was not executing it has purpose.
What we really need to do is move it to a runtime check of the client not the system.
Member
Author
There was a problem hiding this comment.
Ah, sorry. I thought it was just working around inconsistencies in GLFW. Will fix.
Member
Author
There was a problem hiding this comment.
I fixed it up and also noticed that support for mouse button key 3 was missing compared to desktop. Added that in as well.
|
|
||
| switch btn { | ||
| case glfw.MouseButton1: | ||
| if rightClick { |
Member
There was a problem hiding this comment.
As above, ctrl+left on macOS should be right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This removes some GOOS checks (likely leftovers from desktop driver) which were never going to be true, makes sure we clean up the pending function to run and also includes some minor cleanups.
Checklist: