NF: Porting Radio button and check box. - #1305
Conversation
maharshi-gor
commented
Jul 22, 2026
maharshi-gor
commented
- Incorporated new icons from @ganimtron-10 for selected state of the radio button.
- Test cases included.
- Tutorial for the same is included.
012f332 to
ab81eaa
Compare
skoudoro
left a comment
skoudoro
left a comment
There was a problem hiding this comment.
Hi @maharshi-gor,
Overall looks good.
It seems there is a bug with radio button since selection should be unique and I succeed to have multiple selected.
Something to dig. (ButtonGroup.select() to look)
| Color of the label text. Accepts a hex string ("#FF0000"), RGB(A) in | ||
| [0, 1], or RGB(A) in [0, 255]. | ||
| position : (float, float), optional | ||
| Absolute coordinates (x, y) of the top-left corner of this component. |
There was a problem hiding this comment.
are you sure top-left corner ? look like vtk, isn't it lower-left now ?
| Color of the label text. Accepts a hex string ("#FF0000"), RGB(A) in | ||
| [0, 1], or RGB(A) in [0, 255]. | ||
| position : (float, float), optional | ||
| Absolute coordinates (x, y) of the top-left corner of this component. |
There was a problem hiding this comment.
are you sure top-left corner ? look like vtk, isn't it lower-left now ?
| Color of the label text. Accepts a hex string ("#FF0000"), RGB(A) in | ||
| [0, 1], or RGB(A) in [0, 255]. | ||
| position : (float, float), optional | ||
| Absolute coordinates (x, y) of the top-left corner of this component. |
There was a problem hiding this comment.
are you sure top-left corner ? look like vtk, isn't it lower-left now ?
| try: | ||
| update() | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
this is weird. ignore all exception ? to remove or put a warning, something
| z_order=0, | ||
| ): | ||
| """Init class instance.""" | ||
| if len(checked_labels) > 1: |
There was a problem hiding this comment.
not compatible with generator. so use len(list(checked_labels))
Strange, I can not reproduce it.... |
|
I confirm the top left is the new convention. I also could not reproduce double checked radio button. But this was a good catch as many places write lower left instead of top left while porting. Working on that. |
-Tutorial provided for the same. -New icons for checkbox and radio button are incorporated for different states. -Lower-top docstrings fixed.
ab81eaa to
d97e5a8
Compare
skoudoro
left a comment
skoudoro
left a comment
There was a problem hiding this comment.
it seems to be ok.
Thank you @maharshi-gor. merging
2 participants
