Skip to content

Improve type hints for SpatialGraph - #31

Merged
tlambert03 merged 7 commits into
funkelab:mainfrom
tlambert03:typing2
Jul 19, 2025
Merged

Improve type hints for SpatialGraph#31
tlambert03 merged 7 commits into
funkelab:mainfrom
tlambert03:typing2

Conversation

@tlambert03

Copy link
Copy Markdown
Member

alternative to #18

this adds a type stub that indicates the methods added by the base cython graph class. I have some thoughts on how to improve this in the future (perhaps turning Graph itself into a factory function rather than a base class...) but will do that later

@codecov-commenter

codecov-commenter commented Jul 19, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.19178% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (1a465ed) to head (24d6f8c).

Files with missing lines Patch % Lines
src/spatial_graph/graph/graph.py 80.76% 10 Missing ⚠️
src/spatial_graph/spatial_graph.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   94.63%   91.10%   -3.53%     
==========================================
  Files           9        9              
  Lines         298      326      +28     
==========================================
+ Hits          282      297      +15     
- Misses         16       29      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 19, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #31 will not alter performance

Comparing tlambert03:typing2 (24d6f8c) with main (1a465ed)

Summary

✅ 6 untouched benchmarks

@tlambert03

Copy link
Copy Markdown
Member Author

all count_ methods should go to num_ methods

@tlambert03
tlambert03 merged commit 1de7c2c into funkelab:main Jul 19, 2025
15 checks passed
@tlambert03
tlambert03 deleted the typing2 branch July 19, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants