Remove reqwest dependency and features - #114
Merged
Merged
Conversation
This crate doesn't need the dependency and the features are just aliases for features in the opentelemetry-http crate. Removing the features means less maintenance work here for reqwest updates and users will only need to wait for opentelemetry-http to support newer reqwuest versions and not this crate in addition.
For some reason the code started to error with:
the trait `tracing_core::field::Value` is not implemented for `dyn std::error::Error`
Stringifying seems like a good enough fix for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate doesn't need the dependency and the features are just aliases for features in the opentelemetry-http crate.
Removing the features means less maintenance work here for reqwest updates and users will only need to wait for opentelemetry-http to support newer reqwuest versions and not this crate in addition.
Fixes #113
Fixes #51