fix: contact uri dropped in config load - #590
Open
ftsef wants to merge 4 commits into
Open
Conversation
SIPUAHelper.start() converts UaSettings.contact_uri (String) into a URI via Utils.normalizeTarget before the config checks run, but the contact_uri check only handled String values. The configured value was silently dropped and the UA registered with a random contact user (createRandomToken) instead of the configured one. This also made via_host fall back to <random>.invalid instead of the contact host. Accept URI instances in the contact_uri check and add config tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The contact_uri check only handled String values, but the field is typed URI? and SIPUAHelper.start() already converts it via normalizeTarget. The value was silently dropped and the UA registered with a random contact user. Copy the URI directly and add config tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes fix an issue where setting the
UaSettings.contact_urihad no effect anymore.In an older version of this library contact_uri was a String
In the latest version
src.contact_uriis anURI?. Therefore checking for aStringdoesn't make sense anymore and leads todst.contact_uribeing always null.