Support standard docker individual secrets#1413
Open
Rycochet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This adds standard docker secrets support for individual environment variables, allowing a server admin to pass values individually.
This follows the "standard" of
<normal_name>_FILEfor variables that support being used as secrets, and updates the readme with information on how to use it. The order of variables is alphabetical (as in the secrets file code).💭 Motivation and context
This allows me to have my "secrets" in an env file outside my docker, and to allow them to be used directly without having to create a specifically formatted (json) file for them.
I have a server stack that I publish open-source, and individual secrets are a more standard way of doing this - the change was minor (although I added extra lines for debugging / logging).
Copied from the updated readme, note that this uses standard secrets, so it is just as possible to use an file as per the config alternative:
🧪 Testing
This changes the
entrypoint.shfile only, and does not have any side-effects beyond adding a_FILEsuffixed alternative to already existing environment variables.All variables
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist