Skip to content

docs(OWNERS): moving andreagit97 to emeritus#3054

Merged
poiana merged 1 commit into
falcosecurity:masterfrom
leogr:andreagit97-emeritus
Jul 14, 2026
Merged

docs(OWNERS): moving andreagit97 to emeritus#3054
poiana merged 1 commit into
falcosecurity:masterfrom
leogr:andreagit97-emeritus

Conversation

@leogr

@leogr leogr commented Jul 14, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This moves @Andreagit97 from approvers to emeritus_approvers, as per his request in falcosecurity/evolution#526.

Thank you for everything, Andrea! 🙏 It won't be the same without you around here, and you're always welcome back.

Which issue(s) this PR fixes:

Part of the step-down tracked in falcosecurity/evolution#526 (not closing it here, since it spans multiple repositories).

Special notes for your reviewer:

Since this is a voluntary step-down, no vote is required - we can merge by lazy consensus.

cc @falcosecurity/core-maintainers

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>

@cpanato cpanato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions

Copy link
Copy Markdown

Perf diff from master - unit tests

    18.22%     -2.62%  [.] sinsp_threadinfo::get_main_thread()
     4.55%     +2.11%  [.] sinsp_thread_manager::create_thread_dependencies(std::shared_ptr<sinsp_threadinfo> const&)
    27.45%     -1.96%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     8.97%     +1.67%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
    12.64%     -0.77%  [.] thread_group_info::get_first_thread() const
     2.16%     +0.69%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     3.47%     +0.46%  [.] sinsp_threadinfo::get_fd_table()
     7.22%     +0.25%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     9.36%     -0.13%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     0.04%     +0.12%  [.] std::basic_string_view<char, std::char_traits<char> >::substr(unsigned long, unsigned long) const

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                                                -0.0213         -0.0212           287           281           287           281
BM_sinsp_split_median                                                              -0.0201         -0.0200           287           282           287           282
BM_sinsp_split_stddev                                                              +1.5584         +1.5570             1             3             1             3
BM_sinsp_split_cv                                                                  +1.6140         +1.6122             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                                      -0.0248         -0.0248            69            67            69            67
BM_sinsp_concatenate_paths_relative_path_median                                    -0.0231         -0.0230            69            67            69            67
BM_sinsp_concatenate_paths_relative_path_stddev                                    -0.5396         -0.5311             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                                        -0.5278         -0.5192             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                                         -0.0244         -0.0243            49            48            49            48
BM_sinsp_concatenate_paths_empty_path_median                                       -0.0137         -0.0136            49            49            49            49
BM_sinsp_concatenate_paths_empty_path_stddev                                       +0.7442         +0.7469             1             1             1             1
BM_sinsp_concatenate_paths_empty_path_cv                                           +0.7879         +0.7904             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                                      -0.0163         -0.0161            66            65            66            65
BM_sinsp_concatenate_paths_absolute_path_median                                    -0.0077         -0.0074            65            65            65            65
BM_sinsp_concatenate_paths_absolute_path_stddev                                    -0.3704         -0.3714             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                                        -0.3599         -0.3611             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_ascii_short_mean                                  +0.0009         +0.0010            15            15            15            15
BM_sinsp_utf8_sanitize_fast_path_ascii_short_median                                +0.0031         +0.0034            15            15            15            15
BM_sinsp_utf8_sanitize_fast_path_ascii_short_stddev                                -0.5520         -0.5467             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_ascii_short_cv                                    -0.5524         -0.5472             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_ascii_long_mean                                   +0.0038         +0.0037            87            87            87            87
BM_sinsp_utf8_sanitize_fast_path_ascii_long_median                                 +0.0009         +0.0008            87            87            87            87
BM_sinsp_utf8_sanitize_fast_path_ascii_long_stddev                                 +0.9484         +0.9534             1             1             1             1
BM_sinsp_utf8_sanitize_fast_path_ascii_long_cv                                     +0.9411         +0.9463             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_multibyte_short_mean                              -0.0328         -0.0328            12            12            12            12
BM_sinsp_utf8_sanitize_fast_path_multibyte_short_median                            -0.0472         -0.0474            12            12            12            12
BM_sinsp_utf8_sanitize_fast_path_multibyte_short_stddev                            +1.1640         +1.1584             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_multibyte_short_cv                                +1.2373         +1.2315             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_multibyte_long_mean                               -0.0733         -0.0733          4105          3804          4104          3803
BM_sinsp_utf8_sanitize_fast_path_multibyte_long_median                             -0.0733         -0.0734          4105          3804          4103          3802
BM_sinsp_utf8_sanitize_fast_path_multibyte_long_stddev                             +0.6202         +1.0703             1             2             1             2
BM_sinsp_utf8_sanitize_fast_path_multibyte_long_cv                                 +0.7483         +1.2340             0             0             0             0
BM_sinsp_utf8_sanitize_fast_path_mixed_long_mean                                   -0.0531         -0.0531          1769          1675          1768          1674
BM_sinsp_utf8_sanitize_fast_path_mixed_long_median                                 -0.0496         -0.0496          1768          1681          1768          1680
BM_sinsp_utf8_sanitize_fast_path_mixed_long_stddev                                 +7.3776         +7.5792             2            21             2            21
BM_sinsp_utf8_sanitize_fast_path_mixed_long_cv                                     +7.8479         +8.0606             0             0             0             0
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_alloc_mean                       -0.0015         -0.0015          1120          1118          1119          1118
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_alloc_median                     +0.0003         +0.0004          1117          1118          1117          1117
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_alloc_stddev                     -0.8536         -0.8540            13             2            13             2
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_alloc_cv                         -0.8533         -0.8538             0             0             0             0
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_noalloc_mean                     -0.0025         -0.0025          1116          1113          1115          1112
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_noalloc_median                   -0.0024         -0.0022          1115          1112          1114          1112
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_noalloc_stddev                   -0.3026         -0.2994             3             2             3             2
BM_sinsp_utf8_sanitize_slow_path_c1_controls_long_noalloc_cv                       -0.3008         -0.2977             0             0             0             0
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_alloc_mean                    -0.0446         -0.0447           247           236           247           236
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_alloc_median                  -0.0452         -0.0453           246           235           246           235
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_alloc_stddev                  -0.3929         -0.3944             4             3             4             3
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_alloc_cv                      -0.3645         -0.3660             0             0             0             0
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_noalloc_mean                  -0.0426         -0.0426           149           142           149           142
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_noalloc_median                -0.0468         -0.0467           149           142           149           142
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_noalloc_stddev                -0.7007         -0.7000             2             1             2             1
BM_sinsp_utf8_sanitize_slow_path_sparse_invalid_long_noalloc_cv                    -0.6874         -0.6866             0             0             0             0
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_alloc_mean                       -0.0368         -0.0368         11686         11257         11683         11252
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_alloc_median                     -0.0469         -0.0468         11670         11122         11665         11119
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_alloc_stddev                     +8.9306         +8.9229            43           431            43           430
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_alloc_cv                         +9.3096         +9.3024             0             0             0             0
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_noalloc_mean                     -0.0863         -0.0864         11450         10462         11446         10458
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_noalloc_median                   -0.0997         -0.0998         11448         10307         11442         10301
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_noalloc_stddev                  +16.4287        +16.1027            21           365            21           365
BM_sinsp_utf8_sanitize_slow_path_all_invalid_long_noalloc_cv                      +18.0746        +17.7191             0             0             0             0

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.94%. Comparing base (6fbc055) to head (b406541).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3054   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files         300      300           
  Lines       33276    33276           
  Branches     5056     5056           
=======================================
  Hits        25271    25271           
  Misses       8005     8005           
Flag Coverage Δ
libsinsp 75.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops ekoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation Bot moved this from Todo to In progress in Falco Roadmap Jul 14, 2026
@poiana

poiana commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, ekoops, leogr, sgaist, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ekoops,leogr,therealbobo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 89269f3 into falcosecurity:master Jul 14, 2026
50 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Falco Roadmap Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants