This repository was archived by the owner on Mar 11, 2021. It is now read-only.
fix(#730): delete objects that are removed from templates - #745
Open
MatousJobanek wants to merge 2 commits into
Open
fix(#730): delete objects that are removed from templates #745MatousJobanek wants to merge 2 commits into
MatousJobanek wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 75.15% 76.61% +1.45%
==========================================
Files 37 38 +1
Lines 3128 3211 +83
==========================================
+ Hits 2351 2460 +109
+ Misses 583 565 -18
+ Partials 194 186 -8
Continue to review full report at Codecov.
|
MatousJobanek
force-pushed
the
issue-730-delete-removed-objects
branch
from
February 15, 2019 14:43
8630aa6 to
a12152c
Compare
Contributor
|
This PR changes one or more of the template files. These changes are now available for testing: Launch in OpenShift.io and click the update tenant button |
MatousJobanek
force-pushed
the
issue-730-delete-removed-objects
branch
from
February 15, 2019 15:11
a12152c to
8212b44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to be reviewed is in this commit 8630aa6
when an object is removed from any of the templates, then during the next update it removes the corresponding object from an associated namespace in OS
the deletion is done by comparing the content of the templates that were used for the update/provisioning of the namespace last time. It takes the version of the namespace and because it represents a commit in tenant repo, then it downloads the content of the template from the corresponding blob. Then it just compares the objects - combination of kind/name/namespace
introduces a caching mechanism to minimize the number of downloads of the previous version of the templates. The cache contains a record for a particular version and for a particular environment type. The actual target of the cache is list of removed objects
is blocked by #741 as it is built on top of it
Fixes: #730