Address review feedback for numeric parse edge cases in parse_util#587
Closed
fabiocaccamo with Copilot wants to merge 1 commit into
Closed
Address review feedback for numeric parse edge cases in parse_util#587fabiocaccamo with Copilot wants to merge 1 commit into
parse_util#587fabiocaccamo with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix code as per all comments in review thread
Address review feedback for numeric parse edge cases in Jul 7, 2026
parse_util
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 64 64
Lines 2399 2399
=======================================
Hits 2359 2359
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This updates the PR to resolve all comments from the linked review thread by tightening
parse_interror handling for float-fallback edge cases and aligningparse_floattyping with its supported inputs.parse_introbustnessint(float(val))) for values like"3.5".None(instead of raising) for overflow/non-finite float conversions (e.g."inf","1e309"), so caller defaults still apply.parse_floattyping alignmentbool | float | int | str) to match runtime behavior and avoid misleading type hints.Tests alignment
Related issue
Addresses the review comments in PR #578 review thread (
pullrequestreview-4629196338).Checklist before requesting a review