Skip to content

Support for multiple arrays per texture - #3438

Merged
Meakk merged 1 commit into
f3d-app:masterfrom
Meakk:multiple-arrays-texture
Aug 24, 2026
Merged

Support for multiple arrays per texture#3438
Meakk merged 1 commit into
f3d-app:masterfrom
Meakk:multiple-arrays-texture

Conversation

@Meakk

@Meakk Meakk commented Aug 10, 2026

Copy link
Copy Markdown
Member

Describe your changes

Reduce the number of used texture in the GLES mapper by appending morph targets to the same texture.
This fixes the crash of dota model on Android.

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I have not used AI to generate any of the content of this pull request
  • I have used AI to generate code in this pull request:
    • I have carefully read and understood the AI policy.
    • I have carefully reviewed and completely understood every generated line.
    • I disclose below which parts of the code were generated and with which AI model:

...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this Aug 10, 2026
@Meakk
Meakk force-pushed the multiple-arrays-texture branch from 4dd1999 to 5760405 Compare August 24, 2026 06:38
@Meakk
Meakk force-pushed the multiple-arrays-texture branch from 5760405 to edfe5e5 Compare August 24, 2026 07:02
@Meakk
Meakk marked this pull request as ready for review August 24, 2026 07:10
@Meakk
Meakk requested a review from a team as a code owner August 24, 2026 07:10
@Meakk
Meakk requested a review from mwestphal August 24, 2026 07:11

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason to not do that all the time ?

@Meakk

Meakk commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

any specific reason to not do that all the time ?

Wdym?

@mwestphal

Copy link
Copy Markdown
Member

any specific reason to not do that all the time ?

Wdym?

If this works for GLES, does it work for non-GLES build ?
If so, should we do it all the time ?

@Meakk

Meakk commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

non-GLES builds use vertex attributes, not textures

@Meakk
Meakk merged commit ab00f44 into f3d-app:master Aug 24, 2026
59 checks passed
@Meakk
Meakk deleted the multiple-arrays-texture branch August 24, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants