Skip to content

fix: recompute axes grid bounds when switching files #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
soumyasavarn wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

fix: recompute axes grid bounds when switching files #2988

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9cbb5f8
fix: recompute axes grid bounds when switching files
soumyasavarn Mar 30, 2026
3159616
style: fix formatting
soumyasavarn Mar 30, 2026
1256a37
test: add recording for TestInteractionAxesGridSwitchFile
soumyasavarn Mar 30, 2026
8c57bee
test: add baseline for TestInteractionAxesGridSwitchFile
soumyasavarn Mar 30, 2026
9440172
fix: correct recording format and remove wrong baseline
soumyasavarn Mar 30, 2026
27960e7
Update vtkext/private/module/vtkF3DRenderer.cxx
soumyasavarn Mar 30, 2026
95741a4
Update application/testing/tests.interaction.cmake
soumyasavarn Mar 30, 2026
41a1ae8
test: add correct baseline for TestInteractionAxesGridSwitchFile
soumyasavarn Mar 30, 2026
c24ded7
fix: reset stale renderer state and request whole-extent on file switch
soumyasavarn May 4, 2026
0d77fe6
Delete testing/baselines/TestInteractionAxesGridSwitchFile.png
soumyasavarn May 4, 2026
66e3c97
fix: use vtkAlgorithm::UpdateWholeExtent for streaming bounds
soumyasavarn May 4, 2026
869e6c5
fix: source axes grid bounds from importer geometry bbox
soumyasavarn May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions application/testing/tests.interaction.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ f3d_test(NAME TestInteractionResetCamera DATA dragon.vtu INTERACTION LONG_TIMEOU
f3d_test(NAME TestInteractionResetCameraWithCameraIndex DATA CameraAnimated.glb ARGS --camera-index=0 INTERACTION) #MouseMovements;Return;
f3d_test(NAME TestInteractionCameraUpdate DATA dragon.vtu INTERACTION) #MouseWheel;MouseWheel;MouseWheel;S
f3d_test(NAME TestInteractionFocalPointPickingDefault DATA dragon.vtu INTERACTION LONG_TIMEOUT)
f3d_test(NAME TestInteractionAxesGridSwitchFile DATA cow.vtp multi/dragon.vtu ARGS --no-config --axes-grid INTERACTION) #Right
Comment thread
soumyasavarn marked this conversation as resolved.
Outdated
f3d_test(NAME TestInteractionFocalPointPickingShift DATA dragon.vtu INTERACTION LONG_TIMEOUT)
f3d_test(NAME TestInteractionFocalPointPickingPoints DATA pointsCloud.vtp INTERACTION THRESHOLD 0.05) # Threshold needed because sometime a point does not appear

Expand Down
6 changes: 6 additions & 0 deletions testing/recordings/TestInteractionAxesGridSwitchFile.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# StreamVersion 1.1
ExposeEvent 0 599 0 0 0 0
RenderEvent 0 599 0 0 0 0
KeyPressEvent 354 650 0 0 1 Right
CharEvent 354 650 0 0 1 Right
KeyReleaseEvent 354 650 0 0 1 Right
1 change: 1 addition & 0 deletions vtkext/private/module/vtkF3DRenderer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2094,6 +2094,7 @@ void vtkF3DRenderer::UpdateActors()
{
this->ActorsPropertiesConfigured = false;
this->GridConfigured = false;
this->GridAxesConfigured = false; // fix: recompute axes grid on file switch
Comment thread
soumyasavarn marked this conversation as resolved.
Outdated
this->MetaDataConfigured = false;
}
this->ImporterTimeStamp = importerMTime;
Expand Down
Loading