Add image(buffer, size) API

[RealEdwardS]

Describe your changes

Add image(buffer, size) API

Requires vtk version that contains CanReadFile(stream) API (> 9.6)
https://gitlab.kitware.com/vtk/vtk/-/commit/675e97fa64a9563f6ec6f1fbf06aba84b2920ea8

Having a bit of trouble finding the right type conversions for Javascript bindings, but a review of what I have so far & feedback would be much appreciated!

Issue ticket number and link if any

Checklist for finalizing the PR

• I have performed a self-review of my code
• I have added tests for new features and bugfixes
• I have added documentation for new features
• If it is a modifying the libf3d API, I have updated bindings
• If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

• I did not use AI to generate any of the content of that pull request
• I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
• ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

[github-actions]

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

[mwestphal]

need some changes, lets focus on the C++ api first.

[mwestphal]

Please request a review when needed :)

[mwestphal]

@RealEdwardS RealEdwardS marked this pull request as ready for review 11 minutes ago

Please actually request a review from a maintainer, top right of the PR :)

[mwestphal]

some changes

[Meakk]

LGTM

[RealEdwardS]

@mwestphal can you check my latest CI? There are 2 macos_arm (commit, bundle, no-static) jobs and in one of them, the TestUSDRigArmatureWithOpacity testcase (which doesn't seem to be relevant to my commits) fails while the other passes. What's the difference between these two jobs?

[mwestphal]

@mwestphal can you check my latest CI? There are 2 macos_arm (commit, bundle, no-static) jobs and in one of them, the TestUSDRigArmatureWithOpacity testcase (which doesn't seem to be relevant to my commits) fails while the other passes. What's the difference between these two jobs?

its a flaky test, you can ignore it

[mwestphal]

Missing webassembly bindings

[mwestphal]

Please check the PR description checkboxes.

[mwestphal]

Missing webassembly bindings

Having a bit of trouble finding the right type conversions for Javascript bindings,

Maybe @Meakk can help ? :)

[RealEdwardS]

Missing webassembly bindings

There were some issues with Webassembly/Emscripten, discussed in this thread, i'm currently skipping it for now

[Meakk]

Maybe something like that?

.class_function("createFromBuffer", +[](emscripten::val jsbuf) -> f3d::image
      {
        std::vector<unsigned char> data = emscripten::vecFromJSArray<unsigned char>(jsbuf);
        return f3d::image(reinterpret_cast<std::byte*>(data.data()), data.size());
      }
)