Skip to content

feature: Add option to configure custom azure servicebus processor options #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwdb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: Add option to configure custom azure servicebus processor options #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/modules/servicebus/Elsa.ServiceBus.AzureServiceBus/Features/AzureServiceBusFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ public AzureServiceBusFeature(IModule module) : base(module)
/// </summary>
public Action<AzureServiceBusOptions> AzureServiceBusOptions { get; set; } = _ => { };

/// <summary>
/// A delegate to create a <see cref="AzureServiceBusOptions"/> instance.
/// </summary>
public Func<IServiceProvider, ServiceBusProcessorOptions> ProcessorOptionsFactory { get; set; } = _ => new ServiceBusProcessorOptions();
Comment on lines +40 to +42

@greptile-apps greptile-apps Bot May 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Incorrect XML doc comment references wrong type

The summary says "A delegate to create a <see cref="AzureServiceBusOptions"/> instance" but the property creates a ServiceBusProcessorOptions instance, not an AzureServiceBusOptions.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/modules/servicebus/Elsa.ServiceBus.AzureServiceBus/Features/AzureServiceBusFeature.cs
Line: 40-42

Comment:
**Incorrect XML doc comment references wrong type**

The summary says "A delegate to create a `<see cref="AzureServiceBusOptions"/>` instance" but the property creates a `ServiceBusProcessorOptions` instance, not an `AzureServiceBusOptions`.

How can I resolve this? If you propose a fix, please make it concise.


/// <summary>
/// A delegate to create a <see cref="ServiceBusAdministrationClient"/> instance.
/// </summary>
Expand Down Expand Up @@ -68,6 +73,7 @@ public override void Apply()
Services
.AddSingleton(ServiceBusAdministrationClientFactory)
.AddSingleton(ServiceBusClientFactory)
.AddSingleton(ProcessorOptionsFactory)

@greptile-apps greptile-apps Bot May 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Singleton ServiceBusProcessorOptions shared across all workers

ProcessorOptionsFactory is registered as a singleton, so every Worker instance — across all queues and topics — receives the exact same ServiceBusProcessorOptions object. If a user needs different concurrency, prefetch, or timeout settings per queue/topic, this design prevents it. Consider documenting this limitation or changing the approach (e.g., a Func<string, string?, ServiceBusProcessorOptions> keyed by queue/subscription).

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/modules/servicebus/Elsa.ServiceBus.AzureServiceBus/Features/AzureServiceBusFeature.cs
Line: 76

Comment:
**Singleton `ServiceBusProcessorOptions` shared across all workers**

`ProcessorOptionsFactory` is registered as a singleton, so every `Worker` instance — across all queues and topics — receives the exact same `ServiceBusProcessorOptions` object. If a user needs different concurrency, prefetch, or timeout settings per queue/topic, this design prevents it. Consider documenting this limitation or changing the approach (e.g., a `Func<string, string?, ServiceBusProcessorOptions>` keyed by queue/subscription).

How can I resolve this? If you propose a fix, please make it concise.

.AddSingleton<ConfigurationQueueTopicAndSubscriptionProvider>()
.AddSingleton<IWorkerManager, WorkerManager>()
.AddScoped<IServiceBusInitializer, ServiceBusInitializer>();
Expand Down
1 change: 1 addition & 0 deletions src/modules/servicebus/Elsa.ServiceBus.AzureServiceBus/Options/AzureServiceBusOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Azure.Messaging.ServiceBus;
using Elsa.ServiceBus.AzureServiceBus.Models;

namespace Elsa.ServiceBus.AzureServiceBus.Options;
Expand Down
5 changes: 2 additions & 3 deletions src/modules/servicebus/Elsa.ServiceBus.AzureServiceBus/Services/Worker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ public class Worker : IAsyncDisposable
/// <summary>
/// Initializes a new instance of the <see cref="Worker"/> class.
/// </summary>
public Worker(string queueOrTopic, string? subscription, ServiceBusClient client, IServiceScopeFactory serviceScopeFactory, ILogger<Worker> logger)
public Worker(string queueOrTopic, string? subscription, ServiceBusClient client, ServiceBusProcessorOptions processorOptions, IServiceScopeFactory serviceScopeFactory, ILogger<Worker> logger)
{
QueueOrTopic = queueOrTopic;
Subscription = subscription == "" ? null : subscription;
_serviceScopeFactory = serviceScopeFactory;
_logger = logger;

var options = new ServiceBusProcessorOptions();
var processor = string.IsNullOrEmpty(subscription) ? client.CreateProcessor(queueOrTopic, options) : client.CreateProcessor(queueOrTopic, subscription, options);
var processor = string.IsNullOrEmpty(subscription) ? client.CreateProcessor(queueOrTopic, processorOptions) : client.CreateProcessor(queueOrTopic, subscription, processorOptions);

processor.ProcessMessageAsync += OnMessageReceivedAsync;
processor.ProcessErrorAsync += OnErrorAsync;
Expand Down