Feature/add azure dev ops#125
Open
RalfvandenBurg wants to merge 12 commits into
Open
Conversation
Greptile SummaryAdds comprehensive Azure DevOps integration module mirroring the existing GitHub integration structure. Implements 15 activities across four categories: Git repositories/branches, pull requests, work items, and builds. Key Changes:
Issues Found:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| src/modules/devops/Elsa.DevOps.AzureDevOps/Services/AzureDevOpsConnectionFactory.cs | Connection factory with PAT token storage in dictionary key and no connection disposal |
| src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/AzureDevOpsActivity.cs | Base activity class with proper validation in CanExecuteAsync |
| src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/PullRequests/CreatePullRequest.cs | Creates pull requests with proper validation and ref normalization |
| src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/WorkItems/UpdateWorkItem.cs | Updates work items, creates connection twice when no changes provided |
| src/modules/devops/Elsa.DevOps.AzureDevOps/Features/AzureDevOpsFeature.cs | Feature registration that adds activities and registers connection factory |
Class Diagram
%%{init: {'theme': 'neutral'}}%%
classDiagram
class AzureDevOpsActivity {
+Input~string~ OrganizationUrl
+Input~string~ Token
#CanExecuteAsync() ValueTask~bool~
#GetConnection() VssConnection
}
class AzureDevOpsConnectionFactory {
-Dictionary~string,VssConnection~ _connections
-SemaphoreSlim _semaphore
+GetConnection(string organizationUrl, string token) VssConnection
}
class AzureDevOpsFeature {
+Apply() void
}
class CreatePullRequest {
+Input~string~ Project
+Input~string~ RepositoryName
+Input~string~ SourceBranch
+Input~string~ TargetBranch
+Output~GitPullRequest~ CreatedPullRequest
}
class CreateWorkItem {
+Input~string~ Project
+Input~string~ WorkItemType
+Input~string~ Title
+Output~WorkItem~ CreatedWorkItem
}
class QueueBuild {
+Input~string~ Project
+Input~int~ DefinitionId
+Output~Build~ QueuedBuild
}
class GetBranch {
+Input~string~ Project
+Input~string~ RepositoryName
+Input~string~ BranchName
+Output~GitBranchStats~ Branch
}
AzureDevOpsActivity <|-- CreatePullRequest
AzureDevOpsActivity <|-- CreateWorkItem
AzureDevOpsActivity <|-- QueueBuild
AzureDevOpsActivity <|-- GetBranch
AzureDevOpsActivity ..> AzureDevOpsConnectionFactory : uses
AzureDevOpsFeature ..> AzureDevOpsConnectionFactory : registers
AzureDevOpsFeature ..> AzureDevOpsActivity : discovers activities
Last reviewed commit: 2bc247e
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…sConnectionFactory.cs Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…nBurg/elsa-extensions into feature/AddAzureDevOps
Namoshek
reviewed
Mar 1, 2026
Namoshek
left a comment
Namoshek
left a comment
Contributor
There was a problem hiding this comment.
I've a bit of experience with the Azure DevOps client libraries and the PR looks good to me. The only thing I miss is a few blank lines to make the code more readable, but I guess that's personal preference. 😉
43 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Elsa.DevOps.AzureDevOps module that mirrors the existing GitHub DevOps extension, enabling Elsa workflows to call Azure DevOps APIs for repositories, pull requests, work items, and builds. It also adds documentation and test coverage (unit + opt-in integration tests) and wires the module into the solution/package set.
Changes:
- Added
Elsa.DevOps.AzureDevOpsmodule with activities for Repos, PRs, Work Items, and Builds, plus a shared base activity and connection factory. - Added README documentation and both unit tests (validation + connection factory) and opt-in integration tests (env-var configured + skippable).
- Updated solution and central packages to include the new module and required Azure DevOps client dependencies.
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/ActivityInputValidation.cs |
Adds shared input validation helpers for activities. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/AzureDevOpsActivity.cs |
Adds the base activity with org URL + PAT inputs and shared connection creation. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/AzureDevOpsTriggerActivity.cs |
Adds a stub trigger base class (NotImplementedException for now). |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/Builds/GetBuild.cs |
Adds “Get Build” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/Builds/ListBuilds.cs |
Adds “List Builds” activity with optional filters. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/Builds/QueueBuild.cs |
Adds “Queue Build” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/PullRequests/CreatePullRequest.cs |
Adds “Create Pull Request” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/PullRequests/GetPullRequest.cs |
Adds “Get Pull Request” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/PullRequests/ListPullRequests.cs |
Adds “List Pull Requests” activity with optional status/top/skip. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/Repositories/GetBranch.cs |
Adds “Get Branch” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/Repositories/GetRepository.cs |
Adds “Get Repository” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/Repositories/ListBranches.cs |
Adds “List Branches” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/WorkItems/CreateWorkItem.cs |
Adds “Create Work Item” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/WorkItems/GetWorkItem.cs |
Adds “Get Work Item” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/WorkItems/QueryWorkItems.cs |
Adds “Query Work Items (WIQL)” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Activities/WorkItems/UpdateWorkItem.cs |
Adds “Update Work Item” activity. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Extensions/ModuleExtensions.cs |
Adds UseAzureDevOps() module extension method. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Features/AzureDevOpsFeature.cs |
Registers the feature, activities, and connection factory. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Services/AzureDevOpsConnectionFactory.cs |
Implements cached VssConnection creation. |
src/modules/devops/Elsa.DevOps.AzureDevOps/Elsa.DevOps.AzureDevOps.csproj |
Adds new module project and package references. |
src/modules/devops/Elsa.DevOps.AzureDevOps/FodyWeavers.xml |
Adds the module’s Fody weavers file (empty). |
src/modules/devops/Elsa.DevOps.AzureDevOps/README.md |
Adds module documentation (install/config/auth/activity list). |
test/modules/devops/Elsa.DevOps.AzureDevOps.UnitTests/Activities/ActivityInputValidationTests.cs |
Adds unit tests for validation helpers. |
test/modules/devops/Elsa.DevOps.AzureDevOps.UnitTests/Services/AzureDevOpsConnectionFactoryTests.cs |
Adds unit tests for connection caching/concurrency/dispose behavior. |
test/modules/devops/Elsa.DevOps.AzureDevOps.UnitTests/Elsa.DevOps.AzureDevOps.UnitTests.csproj |
Adds unit test project for the module. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/Fixtures/AzureDevOpsFixture.cs |
Adds env-var configured fixture + skip logic for integration tests. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/Services/ConnectionFactoryIntegrationTests.cs |
Adds basic integration coverage for authentication/connection. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/Repositories/RepositoriesIntegrationTests.cs |
Adds integration coverage for repo/branch APIs. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/PullRequests/PullRequestsIntegrationTests.cs |
Adds integration coverage for PR listing/get-by-id. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/WorkItems/WorkItemsIntegrationTests.cs |
Adds integration coverage for WIQL/create/update work items. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/Builds/BuildsIntegrationTests.cs |
Adds integration coverage for build listing/get-by-id. |
test/modules/devops/Elsa.DevOps.AzureDevOps.IntegrationTests/Elsa.DevOps.AzureDevOps.IntegrationTests.csproj |
Adds integration test project + SkippableFact dependency. |
Directory.Packages.props |
Adds central versions for Azure DevOps client libraries. |
Elsa.Extensions.sln |
Adds the new module and test projects to the solution. |
README.md |
Updates the extensions status table entry for Azure DevOps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+20
to
+43
| public VssConnection GetConnection(string organizationUrl, string token) | ||
| { | ||
| var key = $"{organizationUrl}|{ComputeHash(token)}"; | ||
| if (_connections.TryGetValue(key, out var connection)) | ||
| return connection; | ||
|
|
||
| try | ||
| { | ||
| _semaphore.Wait(); | ||
|
|
||
| if (_connections.TryGetValue(key, out connection)) | ||
| return connection; | ||
|
|
||
| var uri = new Uri(organizationUrl.TrimEnd('/')); | ||
| var credentials = new VssBasicCredential(string.Empty, token); | ||
| connection = new VssConnection(uri, credentials); | ||
| _connections[key] = connection; | ||
| return connection; | ||
| } | ||
| finally | ||
| { | ||
| _semaphore.Release(); | ||
| } | ||
| } |
Comment on lines
+12
to
+22
| public class AzureDevOpsFeature(IModule module) : FeatureBase(module) | ||
| { | ||
| /// <summary> | ||
| /// Applies the feature to the specified service collection. | ||
| /// </summary> | ||
| public override void Apply() | ||
| { | ||
| Module.AddActivitiesFrom<AzureDevOpsFeature>(); | ||
| Services.AddSingleton<AzureDevOpsConnectionFactory>(); | ||
| } | ||
| } |
Comment on lines
+60
to
+71
| var project = context.Get(Project); | ||
| var repositoryName = context.Get(RepositoryName); | ||
| var top = context.Get(Top); | ||
| var skip = context.Get(Skip); | ||
| var (projectOk, projectErr) = ActivityInputValidation.TryValidateRequired(project, nameof(Project)); | ||
| if (!projectOk) { context.AddExecutionLogEntry("Precondition Failed", projectErr); return new ValueTask<bool>(false); } | ||
| var (repoOk, repoErr) = ActivityInputValidation.TryValidateRequired(repositoryName, nameof(RepositoryName)); | ||
| if (!repoOk) { context.AddExecutionLogEntry("Precondition Failed", repoErr); return new ValueTask<bool>(false); } | ||
| if (top is < 0) { context.AddExecutionLogEntry("Precondition Failed", "'Top' must be non-negative when specified."); return new ValueTask<bool>(false); } | ||
| if (skip is < 0) { context.AddExecutionLogEntry("Precondition Failed", "'Skip' must be non-negative when specified."); return new ValueTask<bool>(false); } | ||
| return base.CanExecuteAsync(context); | ||
| } |
Comment on lines
+63
to
+67
| var build = new Build | ||
| { | ||
| Definition = new BuildDefinitionReference { Id = definitionId }, | ||
| SourceBranch = sourceBranch ?? "refs/heads/main" | ||
| }; |
Comment on lines
+194
to
+195
| <PackageVersion Include="Microsoft.TeamFoundationServer.Client" Version="19.225.2"/> | ||
| <PackageVersion Include="Microsoft.VisualStudio.Services.Client" Version="19.225.2"/> |
Member
|
Hi @RalfvandenBurg, Great PR! If you're able to review these comments, I'll get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Elsa.DevOps.AzureDevOps module to integrate Azure DevOps with Elsa Workflows. The implementation mirrors the structure and patterns of Elsa.DevOps.GitHub so workflows can call Azure DevOps Git, pull requests, work items, and builds from activities.
Closes #124