Skip to content

Fix/7577 Fix ElsaContext Auto Migrations EfCore9 + MSSQL + Custom Elsa db schema (PendingModelChanges error)#7578

Open
fgollas wants to merge 11 commits into
elsa-workflows:rc/2.15.1from
fgollas:fix/7577
Open

Fix/7577 Fix ElsaContext Auto Migrations EfCore9 + MSSQL + Custom Elsa db schema (PendingModelChanges error)#7578
fgollas wants to merge 11 commits into
elsa-workflows:rc/2.15.1from
fgollas:fix/7577

Conversation

@fgollas

@fgollas fgollas commented Jun 1, 2026

Copy link
Copy Markdown

Purpose

The PR is intended to fix Startup issue with Auto Migrations for EFCore9 with MSSQL and a custom schema for ElsaContext: #7577

When using a custom schema for ElsaContext, consumers should no more see EFCore's PendingModelChanges event which (if unhandled) can lead to an unhandled exception in Elsa's MigrationRunner causing the application to crash on startup.

Targeting Elsa 2.16.1


Scope

Select one primary concern:

  • [x ] Bug fix (behavior change)
  • Refactor (no behavior change)
  • Documentation update
  • Formatting / code cleanup
  • Dependency / build update
  • New feature

Description

Problem

See #7577

Solution

If a custom elsa schema is potentially set by the consumer, a custom IMigrationsModelDiffer is applied to EFCore which detects a custom schema and suppresses the current PendingModelChanges event.


Verification

Steps:

  1. Create a .net10 sample console app referencing the patched elsa 2.16.x versions
  2. Configure elsa persistence to use mssql via EfCore and ElsaContext to use a custom schema (for example Elsa-Test) instead of the default Elsa.
  3. Ensure migrations/snapshot are based on default schema mappings (existing Elsa snapshot behavior).
  4. Start the application (or run migration validation/startup path that checks model drift).

Hint: Alternatively you can checkout the sample app used to reproduce the issue, upgrade to the patched elsa version and run it to verify it starts properly: https://github.com/fgollas/elsa-bugreport-pendingmodelchanges-2.1.16/tree/main

Expected outcome:
Startup should succeed, especially no Crash or error related to PendingModelChangesWarning should be visible in the output.


Screenshots / Recordings (if applicable)

N/A

Commit Convention

We recommend using conventional commit prefixes:

  • fix: – Bug fixes (behavior change)
  • feat: – New features
  • refactor: – Code changes without behavior change
  • docs: – Documentation updates
  • chore: – Maintenance, tooling, or dependency updates
  • test: – Test additions or modifications

Clear commit messages make reviews easier and history more meaningful.


Checklist

  • [ x ] The PR is focused on a single concern
  • Commit messages follow the recommended convention
  • [ x ] Tests added or updated (if applicable) -> not applicable
  • [ x ] Documentation updated (if applicable) -> not applicable
  • [ x ] No unrelated cleanup included
  • [ x ] All tests pass

Slettan and others added 11 commits April 12, 2025 10:57
Use Enumerate(TemplateContext) instead of Enumerate() (which is obsolete and returns an empty array)
…ttribute (elsa-workflows#6631)

* fix: versioning nuget package changed from deprecated one to asp versioning for elsa server api

* fix: iformfile attributes removed from workflowdefinitions endpoint

---------

Co-authored-by: Selin Koykiran <selin.koykiran@siemens.com>
* Added .Net10 support

* deleted icon

---------

Co-authored-by: Beka Kvariani <bkvariani@tbcbank.com.ge>
…flows#7377)

- Bump project version to 2.16.
- Add Swashbuckle.AspNetCore packages for .NET 10.0 builds.
- Refactor XEnumNamesSchemaFilter with conditional logic for .NET 10.0+ using new OpenAPI APIs.
- Update ServiceCollectionExtensions to use new schema types and mappings for .NET 10.0+.
- Preserve compatibility with earlier .NET versions.
…ws#7363)

* fix(eslint): remove eslint from productiv dependencies

ESlint should be used as dev dependency only.

* chore(eslint): align version of eslint
…a custom schema for ElsaContext. In EFCore9 Microsoft validates Migrations snapshot schema ('Elsa') against the deployed schema (custom, like 'MyElsa') and throws with RelationalEventId.PendingModelChangesWarning event if those schemas differ.
@greptile-apps

greptile-apps Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@dotnet-policy-service

Copy link
Copy Markdown

@fgollas please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

@fgollas

fgollas commented Jun 10, 2026

Copy link
Copy Markdown
Author

@dotnet-policy-service agree company="MMI"

@fgollas
fgollas changed the base branch from main to rc/2.15.1 June 10, 2026 11:28

Copy link
Copy Markdown
Member

Thanks for taking the time to put this together.

I agree with the problem described in #7577, but this PR is too broad for us to review and merge safely as a bug fix. Besides the EF Core / SQL Server custom-schema migration behavior, it also changes target frameworks, package versions, API versioning/OpenAPI code, publishing configuration, and package lock files across unrelated areas.

Could you please narrow this PR to only the PendingModelChanges / custom Elsa schema fix?

The ideal shape would be:

Once the PR is scoped to that single issue, it should be much easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants