Show cancelling workflow state immediately#7528
Conversation
|
PR author is not in the allowed authors list. |
|
@aidevelopers2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
There was a problem hiding this comment.
Pull request overview
Adds an intermediate Cancelling workflow sub-status so cancellation requests are reflected immediately (before background cancellation completes), improving UI/API consistency during bulk cancellation operations.
Changes:
- Introduce
WorkflowSubStatus.Cancellingin core and API client enums. - Persist non-finished workflow instances as
Running/Cancelling(includingWorkflowState) before dispatching cancellation work. - Add unit tests covering the save-before-dispatch behavior and the “instance not found” path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/Elsa.Workflows.Runtime.UnitTests/Services/WorkflowCancellationServiceTests.cs | Verifies instances are persisted as Cancelling before dispatch and that missing instances do not dispatch. |
| src/modules/Elsa.Workflows.Runtime/Services/WorkflowCancellationService.cs | Marks cancellable instances as Running/Cancelling and saves them before dispatching cancellation requests. |
| src/modules/Elsa.Workflows.Core/Enums/WorkflowSubStatus.cs | Adds the Cancelling sub-status to the core enum. |
| src/modules/Elsa.Workflows.Core/Contexts/WorkflowExecutionContext.cs | Maps Cancelling to main Running status for execution-context status derivation. |
| src/clients/Elsa.Api.Client/Resources/WorkflowInstances/Enums/WorkflowSubStatus.cs | Adds Cancelling to the API client enum to keep it in sync with server responses. |
Summary
Cancellingworkflow sub-status for accepted cancellation requestsRunning/Cancellingbefore dispatching background cancellation workCancelledFixes #5187
Tests
.nuke/temp/dotnet-unix/dotnet test test/unit/Elsa.Workflows.Runtime.UnitTests/Elsa.Workflows.Runtime.UnitTests.csproj --filter WorkflowCancellationServiceTests