Do not await bookmark scheduling on application start to prevent startup from hanging#7524
Open
jwdb wants to merge 1 commit into
Open
Conversation
… startup from hanging
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will have to say this is my suggestion on fixing the problem directly, there might be a better way of solving this problem. For example by moving the entire scheduling into a background worker instead of running directly in the tenant activated event.
Purpose
This makes the Application not wait for all the bookmarks to be queued before continueing the start of the application.
Scope
Select one primary concern:
Description
Problem
this solves the problem described in #7470
Solution
By not awaiting the scheduling of the bookmarks, the program flow will continue and not hang the IHostedService responsible of activating the tenants
Verification
This can be verified by queuing a large amount of bookmarks and restarting the application. After this change the startup will continue while the log wil show the bookmarks are still being enqueued
Checklist