Skip to content

Do not await bookmark scheduling on application start to prevent startup from hanging#7524

Open
jwdb wants to merge 1 commit into
elsa-workflows:mainfrom
jwdb:Fix/Do-not-await-bookmark-queuing-on-application-start
Open

Do not await bookmark scheduling on application start to prevent startup from hanging#7524
jwdb wants to merge 1 commit into
elsa-workflows:mainfrom
jwdb:Fix/Do-not-await-bookmark-queuing-on-application-start

Conversation

@jwdb

@jwdb jwdb commented May 21, 2026

Copy link
Copy Markdown
Contributor

I will have to say this is my suggestion on fixing the problem directly, there might be a better way of solving this problem. For example by moving the entire scheduling into a background worker instead of running directly in the tenant activated event.

Purpose

This makes the Application not wait for all the bookmarks to be queued before continueing the start of the application.


Scope

Select one primary concern:

  • Bug fix (behavior change)
  • Refactor (no behavior change)
  • Documentation update
  • Formatting / code cleanup
  • Dependency / build update
  • New feature

Description

Problem

this solves the problem described in #7470

Solution

By not awaiting the scheduling of the bookmarks, the program flow will continue and not hang the IHostedService responsible of activating the tenants


Verification

This can be verified by queuing a large amount of bookmarks and restarting the application. After this change the startup will continue while the log wil show the bookmarks are still being enqueued


Checklist

  • The PR is focused on a single concern
  • Commit messages follow the recommended convention
  • Tests added or updated (if applicable)
  • Documentation updated (if applicable)
  • No unrelated cleanup included
  • All tests pass

@greptile-apps

greptile-apps Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant